-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rgbds: 0.5.1 -> 0.5.2 #149232
rgbds: 0.5.1 -> 0.5.2 #149232
Conversation
I don't think it's supposed to fail on Darwin. FWIW, it is a supported target upstream. Moreover, I don't see what could cause 0.5.x to fail on Darwin – I don't see any changes that could cause it in the git log for the Makefile. I don't have a Mac I could use to debug this, but perhaps building with cmake instead could help? |
Darwin builds for v0.5.1 are already failing on Hydra. I wanted to solve that along with the update. But OK let's ask @NixOS/darwin-maintainers if someone can maybe build this locally and solve the linking issue?
|
We might also want to add `Q=` to the make flags, so that the logs are more verbose.
|
Building with |
Seems to be the same problem as #19098. I added the following, and the derivation built on aarch64-darwin.
|
Thanks @reckenrode |
@GrahamcOfBorg build rgbds |
Last commit pushed already triggered ofBorg's eval and rebuilds @prusnak Great it now builds on all platforms \o/ |
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/rgbds/versions.
meta.description for rgbds is: "A free assembler/linker package for the Game Boy and Game Boy Color"
meta.homepage for rgbds is: "https://rgbds.gbdev.io/"
meta.changelog for rgbds is: ""
Updates performed
To inspect upstream changes
Release on GitHub
Compare changes on GitHub
Impact
Checks done (click to expand)
passthru.tests
, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review
run on x86_64-linux 12 packages built:
Maintainer pings
cc @matthewbauer @NieDzejkob for testing.