rgbds: 0.5.1 -> 0.5.2

[r-ryantm]

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/rgbds/versions.

meta.description for rgbds is: "A free assembler/linker package for the Game Boy and Game Boy Color"

meta.homepage for rgbds is: "https://rgbds.gbdev.io/"

meta.changelog for rgbds is: ""

Updates performed

• Version update

To inspect upstream changes

• Release on GitHub

• Compare changes on GitHub

Impact

Checks done (click to expand)

---

• built on NixOS
• The tests defined in passthru.tests, if any, passed
• /nix/store/bfq4av32wahnp792adx4zba5aznv6ja7-rgbds-0.5.2/bin/rgblink passed the binary check.
• /nix/store/bfq4av32wahnp792adx4zba5aznv6ja7-rgbds-0.5.2/bin/rgbasm passed the binary check.
• /nix/store/bfq4av32wahnp792adx4zba5aznv6ja7-rgbds-0.5.2/bin/rgbfix passed the binary check.
• /nix/store/bfq4av32wahnp792adx4zba5aznv6ja7-rgbds-0.5.2/bin/rgbgfx passed the binary check.
• 4 of 4 passed binary check by having a zero exit code.
• 4 of 4 passed binary check by having the new version present in output.
• found 0.5.2 with grep in /nix/store/bfq4av32wahnp792adx4zba5aznv6ja7-rgbds-0.5.2
• found 0.5.2 in filename of file in /nix/store/bfq4av32wahnp792adx4zba5aznv6ja7-rgbds-0.5.2

---

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
2 x86_64-darwin rebuild(s)


First fifty rebuilds by attrpath
docbookrx
rgbds
sameboy

Instructions to test this update (click to expand)

---

Either download from Cachix:

nix-store -r /nix/store/bfq4av32wahnp792adx4zba5aznv6ja7-rgbds-0.5.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A rgbds https://github.com/r-ryantm/nixpkgs/archive/7b90792ac300afc703e57a56211928a81341b171.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/bfq4av32wahnp792adx4zba5aznv6ja7-rgbds-0.5.2
ls -la /nix/store/bfq4av32wahnp792adx4zba5aznv6ja7-rgbds-0.5.2/bin

---

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

• rgbds
• sameboy

---

Maintainer pings

cc @matthewbauer @NieDzejkob for testing.

[meithecatte]

I don't think it's supposed to fail on Darwin. FWIW, it is a supported target upstream. Moreover, I don't see what could cause 0.5.x to fail on Darwin – I don't see any changes that could cause it in the git log for the Makefile.

I don't have a Mac I could use to debug this, but perhaps building with cmake instead could help?

[c0bw3b]

Darwin builds for v0.5.1 are already failing on Hydra. I wanted to solve that along with the update.

But OK let's ask @NixOS/darwin-maintainers if someone can maybe build this locally and solve the linking issue?

ld: warning: ld: warning: ignoring file src/asm/charmap.o, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0xDE 0xC0 0x17 0x0B 0x00 0x00 0x00 0x00 0x14 0x00 0x00 0x00 0x4C 0x28 0x00 0x00 )ignoring file src/asm/fixpoint.o, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0xDE 0xC0 0x17 0x0B 0x00 0x00 0x00 0x00 0x14 0x00 0x00 0x00 0xA8 0x22 0x00 0x00 )

[meithecatte]

We might also want to add `Q=` to the make flags, so that the logs are more verbose.

[c0bw3b]

Building with clangStdenv on Linux doesn't reproduce the issue.

[reckenrode]

Seems to be the same problem as #19098. I added the following, and the derivation built on aarch64-darwin.

NIX_CFLAGS_COMPILE = lib.optional stdenv.isDarwin "-fno-lto";

[c0bw3b]

Thanks @reckenrode
It adds up: upstream added -flto in v0.5.0 with commit gbdev/rgbds@b598911

[prusnak]

@GrahamcOfBorg build rgbds

[c0bw3b]

Last commit pushed already triggered ofBorg's eval and rebuilds @prusnak

Great it now builds on all platforms \o/