Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mxu11x0: 1.4 -> 4.1 #148045

Merged
merged 1 commit into from
Dec 3, 2021
Merged

mxu11x0: 1.4 -> 4.1 #148045

merged 1 commit into from
Dec 3, 2021

Conversation

arkivm
Copy link
Contributor

@arkivm arkivm commented Nov 30, 2021

Motivation for this change

Multiple hydra failures on mxu driver
kernel versions: v4.9 to v5.13

ZHF: #144627

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from uralbash November 30, 2021 20:14
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Nov 30, 2021
@uralbash
Copy link
Member

uralbash commented Dec 1, 2021

@ofborg Could you explain me how to apply these changes on my NixOS version 21.11 for check moxa uport converter with this driver

@arkivm
Copy link
Contributor Author

arkivm commented Dec 2, 2021

@uralbash could you try applying this patch if you have a local checkout and do
nix-build -KA linuxKernel.packages.linux_x_y.mxu11x0 (replace x_y with your version)? The modules should be in your ./result/lib/path/to/mod/mxu...ko. If you are not on a nixos supported kernel, you can build your own or override the versions as mentioned in this wiki.
Unfortunately, I don't have a hardware to test.

Copy link
Member

@uralbash uralbash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked MOXA UPort 1130 equipment in mode RS-485 on NixOS 21.11 with 5.10.81 Linux Kernel. The essence of the experiment to transfer data through RS-485 line. Technique was to connect two converters (UPort 1130) among themselves and get the echo signal.

PC (NixOS) - USB0 <-----UPort1130 
          |               |A   | B
          |               |    |
          |               |A   | B
           \ - USB1 <------UPort1130 

image
I can confirm that it works on real equipment

@arkivm
Copy link
Contributor Author

arkivm commented Dec 3, 2021

@uralbash: Great. Thank you for testing it on real hw

@baloo
Copy link
Member

baloo commented Dec 3, 2021

@ofborg eval

@ofborg ofborg bot requested a review from uralbash December 3, 2021 08:46
@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 148045 run on x86_64-linux 1

19 packages marked as broken and skipped:
  • linuxKernel.packages.hardkernel_4_14.mxu11x0
  • linuxKernel.packages.linux_5_14.mxu11x0
  • linuxKernel.packages.linux_5_14_hardened.mxu11x0
  • linuxKernel.packages.linux_5_15.mxu11x0
  • linuxKernel.packages.linux_5_15_hardened.mxu11x0
  • linuxKernel.packages.linux_latest_libre.mxu11x0
  • linuxKernel.packages.linux_lqx.mxu11x0
  • linuxKernel.packages.linux_testing_bcachefs.mxu11x0
  • linuxKernel.packages.linux_xanmod.mxu11x0
  • linuxKernel.packages.linux_zen.mxu11x0
  • linuxPackages_5_14_hardened.mxu11x0
  • linuxPackages_5_15_hardened.mxu11x0
  • linuxPackages_hardkernel_latest.mxu11x0
  • linuxPackages_latest-libre.mxu11x0
  • linuxPackages_latest.mxu11x0
  • linuxPackages_lqx.mxu11x0
  • linuxPackages_testing_bcachefs.mxu11x0
  • linuxPackages_xanmod.mxu11x0
  • linuxPackages_zen.mxu11x0
11 packages built:
  • linuxKernel.packages.linux_4_14.mxu11x0
  • linuxPackages_4_14_hardened.mxu11x0 (linuxKernel.packages.linux_4_14_hardened.mxu11x0)
  • linuxKernel.packages.linux_4_19.mxu11x0
  • linuxPackages_4_19_hardened.mxu11x0 (linuxKernel.packages.linux_4_19_hardened.mxu11x0)
  • linuxKernel.packages.linux_4_4.mxu11x0
  • linuxKernel.packages.linux_4_9.mxu11x0
  • linuxPackages.mxu11x0 (linuxKernel.packages.linux_5_10.mxu11x0)
  • linuxPackages_hardened.mxu11x0 (linuxPackages_5_10_hardened.mxu11x0)
  • linuxKernel.packages.linux_5_4.mxu11x0
  • linuxPackages_5_4_hardened.mxu11x0 (linuxKernel.packages.linux_5_4_hardened.mxu11x0)
  • linuxPackages-libre.mxu11x0 (linuxKernel.packages.linux_libre.mxu11x0)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

Successfully created backport PR #148461 for release-21.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants