Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsung: use Python 3 #147536

Merged
merged 1 commit into from
Nov 27, 2021
Merged

tsung: use Python 3 #147536

merged 1 commit into from
Nov 27, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Nov 26, 2021

Motivation for this change

Switch to use Python 3

Fix build (https://hydra.nixos.org/build/159672658)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Nov 26, 2021

Result of nixpkgs-review pr 147536 run on x86_64-linux 1

1 package built:
  • tsung

@ofborg ofborg bot requested a review from uskudnik November 26, 2021 21:55
@thiagokokada
Copy link
Contributor

Should we backport to release-21.11 🤔 ?

@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 147536 run on x86_64-linux 1

1 package built:
  • tsung

@fabaff fabaff merged commit 8a3c016 into NixOS:master Nov 27, 2021
@fabaff fabaff deleted the fix-tsung branch November 27, 2021 08:15
@github-actions github-actions bot mentioned this pull request Nov 27, 2021
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #147571 for release-21.11.

@thiagokokada thiagokokada mentioned this pull request Nov 28, 2021
Closed
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@uskudnik uskudnik Awaiting requested review from uskudnik

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabaff @thiagokokada