python3Packages.nbclient: 0.5.8 -> 0.5.9, fix build #146813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also unbreaks the build, as for some reason the bin directory is empty when doCheck = true and then the postFixup fails.
ofborg
bot
added
11.by: package-maintainer
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 4 packages marked as broken and skipped:
30 packages failed to build and already failed to build on hydra master:
1 package failed to build and are new build failure:
102 packages built:
The following issues got detected with the above build packages.
ihaskell:
warning: unused-argument |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes the build failure introduced in #146151, as for some reason the bin directory is empty when doCheck = true and then the postFixup failed.
0.5.9 contains jupyter/nbclient#173 so no need for the
postFixupanymore.This should also close #146277.
The original issue was #145968.
Run
for testing.
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes