python3Packages.sanic: disable failing tests on aarch64-linux #145022
Conversation
| # Some tests depends on sanic on PATH | ||
| PATH="$out/bin:$PATH" |
There was a problem hiding this comment.
My mistake on the previous PR. Gunicorn is already on checkInputs so it should be already available on PATH.
It is just sanic itself that isn't.
|
Result of 2 packages marked as broken and skipped:
13 packages built:
|
|
Result of 2 packages marked as broken and skipped:
3 packages failed to build:
10 packages built:
|
| "test_server_run" | ||
| "test_host_port" | ||
| "test_num_workers" | ||
| "test_access_logs" |
There was a problem hiding this comment.
what are the underlying errors. I feel like a lot of these shouldn't be specific to aarch64
There was a problem hiding this comment.
https://hydra.nixos.org/build/157553084/nixlog/1
I think at least some of them are related to timing errors, maybe because aarch64 is slower than x86_64 🤔 (I don't know which machines are Hydra running for aarch64).
There was a problem hiding this comment.
do you mind saying a long the lines of, "these appear to be very sensitive to output of commands. output is different on aarch64"
There was a problem hiding this comment.
@jonringer Any other issue? Can we get this merged?
|
@ofborg build python38Packages.sanic python39Packages.sanic |
|
I removed some tests that are probably failing because I was using emulation to test locally. It seems to work at least on Ofborg: https://github.com/NixOS/nixpkgs/pull/145022/checks?check_run_id=4139712392 |
|
@SuperSandro2000 can I have a review here? |
Motivation for this change
ZHF: #144627
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)