zld: init at 1.3.3 #143211
Closed
zld: init at 1.3.3 #143211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 27, 2021 11:55
ofborg
bot
added
10.rebuild-darwin: 0
| pname = "zld"; | ||
| version = "1.3.3"; | ||
| src = fetchzip { | ||
| url = "https://github.com/michaeleisel/zld/releases/download/${version}/zld.zip"; |
There was a problem hiding this comment.
Please compile the project.
| license = licenses.mit; | ||
| maintainers = [ maintainers.rgnns ]; | ||
| platforms = platforms.darwin; | ||
| hydraPlatforms = []; |
There was a problem hiding this comment.
Why not build it on hydra?
|
I completely agree that we should build it from source. However in the meanwhile, no one has access to it. Let's merge this for now and then when someone has time and motivation we can improve this. |
|
@rgnns could you just rebase your changes when you have a moment ? |
|
Sorry, I hadn't had time to go back to this. I'll rebase and revisit building it later, I think I was close to getting that done. |
|
Unfortunately, seems like I made some cleanup to my Github forks and must have accidentally deleted nixpkgs which had my work. I created a new pull request with the changes: #164663 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
zldis a faster linker than Apple's linker.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)