pantheon.evince: init #140828
Merged
pantheon.evince: init #140828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: GNOME
ofborg
bot
added
11.by: package-maintainer
| @@ -40,6 +42,7 @@ | |||
| , supportMultimedia ? true # PDF multimedia | |||
| , libgxps | |||
| , supportXPS ? true # Open XML Paper Specification via libgxps | |||
| , withPantheon ? false | |||
There was a problem hiding this comment.
Is there a reason to build it without?
There was a problem hiding this comment.
I think with withPantheon enabled, evince will only respect dark mode setting from Pantheon and no longer respect gtk-application-prefer-dark-theme from ~/.config/gtk-3.0/settings.ini. Though I guess things will change soon (see this blog post).
|
Rebased and I guess this is ready for review? (just noticed that evince isn't updated in the GNOME 41 PR) |
|
Result of 1 package blacklisted:
1 package failed to build:
1 package built:
|
|
The package builds and works. When i rebuild my system from the PR, tracker package fails. Might be unrelated to this change. |
|
@davidak can you reproduce issue repeatedly? What happens when you try to apply the following patch to tracker: git clone https://gitlab.gnome.org/GNOME/tracker.git
cd tracker/
git checkout 3.2.0
git apply <(curl -L https://gist.github.com/jtojnar/dfa8212436631ecfd63d2a8f716b7964/raw/45cfb2093c7b5f4fd1f545670e352d6f1e091eb7/tracker-test.patch)diff --git a/pkgs/development/libraries/tracker/default.nix b/pkgs/development/libraries/tracker/default.nix
index 39ac21b7ad6..ae9b25d3579 100644
--- a/pkgs/development/libraries/tracker/default.nix
+++ b/pkgs/development/libraries/tracker/default.nix
@@ -32,12 +32,9 @@ stdenv.mkDerivation rec {
pname = "tracker";
version = "3.2.0";
- outputs = [ "out" "dev" "devdoc" ];
+ outputs = [ "out" "dev" /*"devdoc"*/ ];
- src = fetchurl {
- url = "mirror://gnome/sources/${pname}/${lib.versions.majorMinor version}/${pname}-${version}.tar.xz";
- sha256 = "sha256-8RelKHXUpNCceqmT+Mio0GRo1dz7FT642qUesThEUTo=";
- };
+ src = /home/jtojnar/Projects/tracker;
patches = [
(substituteAll {
@@ -81,7 +78,7 @@ stdenv.mkDerivation rec {
];
mesonFlags = [
- "-Ddocs=true"
+ "-Ddocs=false"
];
doCheck = true; |
yes. happened in 5/5 cases
i get a similar issue |
|
Opened an issue upstream: https://gitlab.gnome.org/GNOME/tracker/-/issues/332 |
|
Do we have to wait for it to be fixed to proceed here? Or should the package be downgraded to a version that works? Probably blocks all that depend on GTK3? |
|
It should not matter, Hydra can build it just fine. Downgrade will not be possible due to libsoup shenanigans (unless backported). |
12 tasks
|
Fix was merged. @bobby285271 can you rebase? |
|
Just realized i can do it myself in my local branch and it shouldn't matter for the PR. |
|
@bobby285271 thanks. The patch fails now. Can you have a look? |
|
Yeah the patch is for evince 40 and I just noticed that evince 41 is in master now. It's 0:57 in UTC+8 and I will do this when I wake up :-) |
bobby285271
force-pushed
the
evince
branch
2 times, most recently
from
d9c7ee1
to
7c1cb70
Compare
jtojnar
reviewed
Oct 17, 2021
davidak
approved these changes
Oct 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Related change:
Sorry for not noticing this before GNOME 41 packaging starts, maybe I should draft this for now?
FYI, we will have similar PR for file-roller soon, see:
pantheon.epiphanyhas already been added in #130380, I will also test the compatibility for that later (update: LGTM)Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)