-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grsecurity: update to linux-4.4 #13505
Conversation
By analyzing the blame information on this pull request, we identified @thoughtpolice, @copumpkin and @wkennington to be potential reviewers |
Sorry. We should decouple grsecurity kernels from the mainline kernels. We have this problem with grsecurity for quite some time. |
Yeah please decouple!
|
c814afb
to
4e3d6d3
Compare
alright, decoupled it, and also fixed up the stable patch |
kernelPatches.mips_ext3_n32 | ||
]; | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have a linux_grsecurity_latest
similar to what the standard kernel has?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, can name it _stable & _testing instead of the version numbers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, what I mean is we have linuxPackages_latest that is simply an "alias" for whatever the latest is.
4_4 would be the specific 4.4 kernel, while latest switches to 4.5 as soon as 4.5 becomes stable.
That way configuring to latest simply requires a rebuild without a configuration change to update.
For example, my config usually has one of these:
kernelPackages = pkgs.linuxPackages_latest;
kernelPackages = pkgs.linuxPackages_testing;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are only used to refer to the appropriate base kernel for grsec internally in patches.nix,
the kernelPackages configuration so far has been set with:
kernelPackages = pkgs.linux_grsec_testing_server;
kernelPackages = pkgs.linux_grsec_stable_server;
So these don't include any version information, but would be indeed good to add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, fixed the versioning, too.
Thanks! Merged, updated to 4.4.4 and also pushed to the 16.03 branch because @domenkozar set the milestone. 🍻 |
Fixes NixOS#13505. (cherry picked from commit eb5a897)
See NixOS#13505. (cherry picked from commit 255d710)
Things done:
nix.useChroot
.Extra
Fixes broken grsecurity due to kernel version change.
(FIXED: I was going to submit this, but by the time I created this pull request @fpletz updated the kernel version to 4.4.3, for which there's no grsecurity patch out yet.)