Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.nvim-expand-expr: init at 2021-08-13 #133844

Merged
merged 2 commits into from
Aug 14, 2021

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Aug 13, 2021

Motivation for this change

Expand and repeat expression to multiple lines for neovim.

https://github.com/allendang/nvim-expand-expr

nixpkgs-review has some failures caused by plenary.nvim

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@figsoda figsoda requested a review from jonringer as a code owner August 13, 2021 23:18
@figsoda figsoda requested a review from lovesegfault August 13, 2021 23:18
@figsoda figsoda mentioned this pull request Aug 13, 2021
11 tasks
@lovesegfault
Copy link
Member

Looks like some annoying regression in the updater :(

@figsoda
Copy link
Member Author

figsoda commented Aug 13, 2021

I reported this under the original pr

@figsoda figsoda marked this pull request as draft August 13, 2021 23:58
@r-rmcgibbo
Copy link

r-rmcgibbo commented Aug 14, 2021

Result of nixpkgs-review pr 133844 at 54556f9e run on aarch64-linux 1

2 packages failed to build:
1 package built successfully:
  • spacevim
2 suggestions:
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


Result of nixpkgs-review pr 133844 at 0b2ff70 run on x86_64-linux 1

7 packages failed to build:
44 packages built successfully:
  • spacevim
  • tests.vim.test_vim_with_vim_nix
  • vimPlugins.Coqtail
  • vimPlugins.LeaderF
  • vimPlugins.aniseed
  • vimPlugins.barbar-nvim
  • vimPlugins.chadtree
  • vimPlugins.conjure
  • vimPlugins.doki-theme-vim
  • vimPlugins.echodoc-vim
  • vimPlugins.fastfold
  • vimPlugins.friendly-snippets
  • vimPlugins.git-worktree-nvim
  • vimPlugins.lexima-vim
  • vimPlugins.lsp-rooter-nvim
  • vimPlugins.lsp_signature-nvim
  • vimPlugins.luasnip
  • vimPlugins.neoterm
  • vimPlugins.nerdtree
  • vimPlugins.null-ls-nvim
  • vimPlugins.nvim-autopairs
  • vimPlugins.nvim-compe
  • vimPlugins.nvim-dap
  • vimPlugins.nvim-expand-expr
  • vimPlugins.nvim-hlslens
  • vimPlugins.nvim-lspconfig
  • vimPlugins.nvim-scrollview
  • vimPlugins.nvim-tree-lua
  • vimPlugins.onedark-nvim
  • vimPlugins.onedark-vim
  • vimPlugins.sql-nvim
  • vimPlugins.taskwiki
  • vimPlugins.vim-devicons
  • vimPlugins.vim-dispatch
  • vimPlugins.vim-fugitive
  • vimPlugins.vim-jsdoc
  • vimPlugins.vim-kitty-navigator
  • vimPlugins.vim-lastplace
  • vimPlugins.vim-test
  • vimPlugins.vim-tpipeline
  • vimPlugins.vim-vsnip
  • vimPlugins.vim-xtabline
  • vimPlugins.vimtex
  • vimPlugins.wilder-nvim
2 suggestions:
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@lovesegfault
Copy link
Member

This needs to be re-done now that #134050 is in :)

@figsoda figsoda marked this pull request as ready for review August 14, 2021 18:16
@SuperSandro2000 SuperSandro2000 merged commit 460360e into NixOS:master Aug 14, 2021
@figsoda figsoda deleted the nvim-expand-expr branch August 15, 2021 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants