Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: fixes installation of 7.15 #13357

Merged
merged 1 commit into from
Feb 22, 2016
Merged

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Feb 21, 2016

It was trying to install /etc/ssl/cert/ca-certificates.pem

See https://hydra.nixos.org/build/32167398/nixlog/1

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @layus, @spwhitt and @the-kenny to be potential reviewers

@zimbatm
Copy link
Member Author

zimbatm commented Feb 21, 2016

7.15 is also at 7.15.5 now

@@ -34,7 +36,7 @@ stdenv.mkDerivation rec {
'';

configureFlags = [
"--with-ca-bundle=/etc/ssl/certs/ca-certificates.crt"
"--with-ca-bundle=/foobar/ca-certificates.crt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can leave this out completely

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zimbatm This reverts a change introduced by @edolstra (9f358f8) following the PR #12748. As you are aware of #8247, how does it fit in the big picture ?
Why not keep this line as is, as you patch already fixes the issue ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this was a left-over from debugging. Fixed in 6908e75

It was trying to install /etc/ssl/cert/ca-certificates.pem

See https://hydra.nixos.org/build/32167398/nixlog/1
globin added a commit that referenced this pull request Feb 22, 2016
curl: fixes installation of 7.15
@globin globin merged commit 60290c6 into NixOS:master Feb 22, 2016
@zimbatm zimbatm deleted the curl-7.15-fixup branch February 22, 2016 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants