cc-wrapper: fix linking against GCC libs for non-GCC #133512
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
clang++
currently links programs statically against libstdc++, which is not expected as upstream clang as well asg++
do not do so. It turns out that whilegccForLibs.lib
contains alibstdc++.so.6
, the specified path does not exist (anymore?), so this change restores the likely intended behavior.Without this change, clang finds a
libstdc++.a
by appending../../..
to the-L
flag above the changed line. Not sure where that is coming from, but with this change the flag order makes it find the .so first./cc @Ericson2314?
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)