Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glibc: use --enable-static-pie only on supported platforms #129004

Merged
merged 1 commit into from
Jul 2, 2021
Merged

glibc: use --enable-static-pie only on supported platforms #129004

merged 1 commit into from
Jul 2, 2021

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented Jul 2, 2021 •
edited
Loading

Motivation for this change

#123989 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@misuzu
glibc: use --enable-static-pie only on supported platforms
33f09f4 
glibc fails to build for armv7l without this change.
@cole-h
Copy link
Member

cole-h commented Jul 2, 2021

@ofborg eval

(Sorry, ofborg's certs recently had an issue, meaning that it was unable to
react to PRs. This has been fixed, but all PRs filed in this period will need
ofborg to be manually kicked off.)

@misuzu misuzu marked this pull request as ready for review July 2, 2021 20:01
@misuzu misuzu requested a review from Mic92 July 2, 2021 20:01
@Mic92 Mic92 merged commit 6ff28fc into NixOS:staging Jul 2, 2021
@ofborg ofborg bot added the 10.rebuild-linux-stdenv This PR causes stdenv to rebuild label Jul 2, 2021
@ofborg ofborg bot requested review from Ma27 and edolstra July 2, 2021 20:54
@misuzu misuzu deleted the glibc-static-pie-fix branch July 3, 2021 04:12
@misuzu misuzu mentioned this pull request Jul 6, 2021
Closed
@Mic92 Mic92 mentioned this pull request Jul 14, 2021
Closed
@vcunat
Copy link
Member

vcunat commented Mar 28, 2022

If I read the announcement for glibc 2.35 right, we'll be able to simply drop the flag, as it should be auto-enabled where supported. /cc PR #165979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@Ma27 Ma27 Awaiting requested review from Ma27

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv This PR causes stdenv to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@misuzu @cole-h @vcunat @Mic92