Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala-runners: init at unstable-2020-02-02 #128060

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

hrhino
Copy link
Contributor

@hrhino hrhino commented Jun 25, 2021

Resubmission of #84068 (apparently you can't push changes and then reopen a PR on github?)

Motivation for this change

It's a good script and useful for testing with pre-release and non-current versions of Scala.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@hrhino hrhino mentioned this pull request Jun 25, 2021
10 tasks
@Artturin
Copy link
Member

the title of the pr and commit should be scala-runners: init at unstable-2020-02-02

@hrhino hrhino changed the title scala-runners: init at 0c0b369 scala-runners: init at unstable-2020-02-02 Jun 25, 2021
@hrhino
Copy link
Contributor Author

hrhino commented Jun 25, 2021

As it now is. Thanks.

This is a script to run multiple versions of scala either by version
number or build hash.
@SuperSandro2000 SuperSandro2000 merged commit b9312e7 into NixOS:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants