Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opencc: 1.0.6 -> 1.1.2 #125606

Merged
merged 1 commit into from
Jun 4, 2021
Merged

opencc: 1.0.6 -> 1.1.2 #125606

merged 1 commit into from
Jun 4, 2021

Conversation

Vonfry
Copy link
Member

@Vonfry Vonfry commented Jun 4, 2021

enable parallel building as well

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@r-rmcgibbo

This comment has been minimized.

enable parallel building as well
@Vonfry
Copy link
Member Author

Vonfry commented Jun 4, 2021

Update: take addvice from @r-rmcgibbo

The other build failures like fcitx5 and librime may be solved in #125609 and #125374 applying patches in rime/librime#367.

@@ -20,9 +20,6 @@ stdenv.mkDerivation rec {
export DYLD_LIBRARY_PATH=$DYLD_LIBRARY_PATH''${DYLD_LIBRARY_PATH:+:}$(pwd)/src
'';

# Parallel building occasionaly fails with: Error copying file "/tmp/nix-build-opencc-1.0.5.drv-0/OpenCC-ver.1.0.5/build/src/libopencc.so.1.0.0" to "/tmp/nix-build-opencc-1.0.5.drv-0/OpenCC-ver.1.0.5/build/src/tools".
Copy link
Member

@sifmelcara sifmelcara Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you know it doesn't randomly fail anymore?

Copy link
Member Author

@Vonfry Vonfry Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sees to have been fixed. BYVoid/OpenCC#322

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jun 4, 2021

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 125606 run on x86_64-linux 1

5 packages failed to build and are new build failures:
  • brise: log was empty
  • fcitx-engines.rime: log was empty
  • fcitx5-rime: log was empty
  • ibus-engines.rime: log was empty
  • librime: log was empty
3 packages built:
  • fcitx5-chinese-addons
  • goldendict
  • opencc

libprime log:

       > [ 77%] Building CXX object src/CMakeFiles/rime.dir/rime/lever/user_dict_manager.cc.o
       > /build/source/src/rime/gear/simplifier.cc: In member function 'bool rime::Opencc::ConvertWord(const string&, std::vector<std::__cxx11::basic_string<char> >*)':
       > /build/source/src/rime/gear/simplifier.cc:57:46: error: cannot convert 'std::__cxx11::basic_string<char>' to 'const char*' in initialization
       >    57 |       for (const char* value : entry->Values()) {
       >       |                                              ^
       > make[2]: *** [src/CMakeFiles/rime.dir/build.make:1213: src/CMakeFiles/rime.dir/rime/gear/simplifier.cc.o] Error 1
       > make[2]: *** Waiting for unfinished jobs....
       > In file included from include/boost/config/header_deprecated.hpp:18,
       >                  from include/boost/pending/integer_log2.hpp:5,
       >                  from include/boost/random/detail/integer_log2.hpp:19,
       >                  from include/boost/random/detail/large_arithmetic.hpp:19,
       >                  from include/boost/random/detail/const_mod.hpp:23,
       >                  from include/boost/random/detail/seed_impl.hpp:26,
       >                  from include/boost/random/mersenne_twister.hpp:30,
       >                  from include/boost/uuid/random_generator.hpp:17,
       >                  from /build/source/src/rime/lever/deployment_tasks.cc:10:
       > include/boost/pending/integer_log2.hpp:7:1: note: '#pragma message: This header is deprecated. Use <boost/integer/integer_log2.hpp> instead.'
       > make[1]: *** [CMakeFiles/Makefile2:212: src/CMakeFiles/rime.dir/all] Error 2
       > make: *** [Makefile:160: all] Error 2
       For full logs, run 'nix log /nix/store/9m5mw6qd7qwi1knivmzxhpsw6mav9wnf-librime-1.5.3.drv'.

@Vonfry
Copy link
Member Author

Vonfry commented Jun 4, 2021

Result of nixpkgs-review pr 125606 run on x86_64-linux 1

8 packages built:
  • brise
  • fcitx-engines.rime
  • fcitx5-chinese-addons
  • fcitx5-rime
  • goldendict
  • ibus-engines.rime
  • librime
  • opencc

@Vonfry
Copy link
Member Author

Vonfry commented Jun 4, 2021

@SuperSandro2000 This has been fixed in #125609 .

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 125606 run on x86_64-linux 1

8 packages built:
  • brise
  • fcitx-engines.rime
  • fcitx5-chinese-addons
  • fcitx5-rime
  • goldendict
  • ibus-engines.rime
  • librime
  • opencc

@SuperSandro2000 SuperSandro2000 merged commit 67a3b2a into NixOS:master Jun 4, 2021
@Vonfry Vonfry deleted the update/opencc branch June 4, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants