Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Packages.starlette: fix build #125213

Merged
merged 1 commit into from
Jun 25, 2021
Merged

[20.09] python3Packages.starlette: fix build #125213

merged 1 commit into from
Jun 25, 2021

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jun 1, 2021 •
edited
Loading

Motivation for this change

Our switch to python 3.8.8+ broke this, because it exposes some breakage and causes a test to fail. Documented encode/starlette#1131 and fixed encode/starlette#1132. Cherry pick that patch to get 20.09's starlette building again.

Apologies to 20.09 users for leaving this broken so long.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@risicle
python3Packages.starlette: fix build
3777863 
newer python 3.8+ releases expose this breakage
encode/starlette#1131, fixed upstream in
encode/starlette#1132
@ofborg ofborg bot requested a review from wd15 June 1, 2021 12:26
@risicle risicle marked this pull request as ready for review June 1, 2021 13:03
@risicle risicle requested review from FRidh and jonringer as code owners June 1, 2021 13:03
@risicle
Copy link
Contributor Author

risicle commented Jun 1, 2021

(package broken on macos due to uvicorn)

@r-rmcgibbo
Copy link

r-rmcgibbo commented Jun 1, 2021 •
edited
Loading

Result of nixpkgs-review pr 125213 at 3777863 run on x86_64-linux 1

8 packages built successfully:
  • datasette (python38Packages.datasette)
  • python37Packages.asgi-csrf
  • python37Packages.datasette
  • python37Packages.fastapi
  • python37Packages.starlette
  • python38Packages.asgi-csrf
  • python38Packages.fastapi
  • python38Packages.starlette

Result of nixpkgs-review pr 125213 at 3777863 run on aarch64-linux 1

8 packages built successfully:
  • datasette (python38Packages.datasette)
  • python37Packages.asgi-csrf
  • python37Packages.datasette
  • python37Packages.fastapi
  • python37Packages.starlette
  • python38Packages.asgi-csrf
  • python38Packages.fastapi
  • python38Packages.starlette

@risicle
Copy link
Contributor Author

risicle commented Jun 25, 2021

I'll take that as an approval ☝️

@risicle risicle merged commit 05b1f3f into NixOS:release-20.09 Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wd15 wd15 Awaiting requested review from wd15

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@risicle @r-rmcgibbo