Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.async-upnp-client: 0.17.0 -> 0.18.0 #124256

Merged
merged 1 commit into from
May 25, 2021
Merged

python3Packages.async-upnp-client: 0.17.0 -> 0.18.0 #124256

merged 1 commit into from
May 25, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 24, 2021 •
edited
Loading

Motivation for this change

Update to latest upstream release 0.18.0

Change log: home-assistant/core#51017

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@fabaff fabaff requested review from FRidh and jonringer as code owners May 24, 2021 12:39
@ofborg ofborg bot requested a review from mweinelt May 24, 2021 12:48
@mweinelt
Copy link
Member

@GrahamcOfBorg test home-assistant

@fabaff
Copy link
Member Author

fabaff commented May 24, 2021

test_bridge_getdevicestatus fails for me with nix-review.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 24, 2021 •
edited
Loading

Result of nixpkgs-review pr 124256 at e0092c38 run on aarch64-linux 1

1 package failed to build:
4 packages built successfully:
  • python38Packages.async-upnp-client
  • python38Packages.openhomedevice
  • python39Packages.async-upnp-client
  • python39Packages.openhomedevice

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Result of nixpkgs-review pr 124256 at e0092c38 run on x86_64-linux 1

1 package failed to build:
4 packages built successfully:
  • python38Packages.async-upnp-client
  • python38Packages.openhomedevice
  • python39Packages.async-upnp-client
  • python39Packages.openhomedevice

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@mweinelt
Copy link
Member

test_bridge_getdevicestatus fails for me with nix-review.

#124165

@fabaff fabaff closed this May 25, 2021
@fabaff fabaff force-pushed the bump-python-smarttub branch from e0092c3 to 34595fb Compare May 25, 2021 21:19
@fabaff fabaff reopened this May 25, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 25, 2021
@fabaff
Copy link
Member Author

fabaff commented May 25, 2021

Result of nixpkgs-review pr 124256 run on x86_64-linux 1

5 packages built:
  • home-assistant
  • python38Packages.async-upnp-client
  • python38Packages.openhomedevice
  • python39Packages.async-upnp-client
  • python39Packages.openhomedevice

@mweinelt mweinelt merged commit acb51e6 into NixOS:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
Home Assistant
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabaff @mweinelt @r-rmcgibbo