Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avocode: add missing deps #123869

Merged
merged 1 commit into from
May 21, 2021
Merged

avocode: add missing deps #123869

merged 1 commit into from
May 21, 2021

Conversation

megheaiulian
Copy link
Contributor

@megheaiulian megheaiulian commented May 21, 2021

Motivation for this change

Currently the latest avocode package binary fails to run because of missing library dependencies.
This PR fixes that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 21, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 123869 at 01f0665 run on x86_64-linux 1

1 package built successfully:
  • avocode
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/graphics/avocode/default.nix:73:3:

       |
    73 |   installPhase = ''
       |   ^
    

@SuperSandro2000 SuperSandro2000 merged commit ea42228 into NixOS:master May 21, 2021
@megheaiulian megheaiulian deleted the feature/avocode-fix branch October 6, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants