Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wslu: init at 3.2.3 #123710

Merged
merged 1 commit into from
May 22, 2021
Merged

wslu: init at 3.2.3 #123710

merged 1 commit into from
May 22, 2021

Conversation

JamieMagee
Copy link
Member

Motivation for this change

Supporting #30391 and https://github.com/Trundle/NixOS-WSL

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 19, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 19, 2021

Result of nixpkgs-review pr 123710 at c0e9fbd3 run on aarch64-linux 1

1 package built successfully:
  • wslu
1 suggestion:
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/tools/system/wslu/default.nix:19:5:

       |
    19 |     license = licenses.gpl3;
       |     ^
    

Result of nixpkgs-review pr 123710 at c0e9fbd3 run on x86_64-linux 1

2 packages built successfully:
  • tests.trivial
  • wslu
1 suggestion:
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/tools/system/wslu/default.nix:19:5:

       |
    19 |     license = licenses.gpl3;
       |     ^
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants