-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/sway: set default wallpaper #122992
Conversation
Yeah, unfortunately not quite, sorry about that... I've drafted #122995 with what I had in mind. |
b77309a
to
22e6693
Compare
22e6693
to
45978fa
Compare
I marked this as stale due to inactivity. → More info |
Still relevant I'd say |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still have to decide if we want to go with this PR or #122995 (which was a bit of an unfortunate situation). IIRC I prefer my approach (duh) but that is certainly open for discussion (plus I have to take another look at it). However, I'd be nice if we could wait until the weekend (for my replies/opinion, the discussion can of course already continue).
@Synthetica9 I assume you prefer your approach, right?
Might be nice to install the Nix-themed or sway-themed wallpaper depending on whether we're running on NixOS or not, but I have no strong preference. Feel free to merge whichever one and close the other. |
Yeah, by default I'd prefer the upstream default from Sway though as I don't really like downstream patches/changes when avoidable. However, I don't know how other community members feel about this and unfortunately we don't have any formal guidelines (at least AFAIK). Anyway, the implementation is fine but I don't really like this approach for the following reasons:
@Synthetica9 so if you're fine with it I'd prefer to go with #122995. It's not perfect either but it seems good enough to me for now. |
Motivation for this change
cc @primeos
See also: https://github.com/Synthetica9/nixpkgs/pull/new/sway-default-wallpaper
The wallpaper shows up in the test, but I don't know if this is what you had in mind.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)