Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebar3-nix: init at 0.1.0 #122632

Merged
merged 2 commits into from
May 17, 2021
Merged

rebar3-nix: init at 0.1.0 #122632

merged 2 commits into from
May 17, 2021

Conversation

dlesl
Copy link
Contributor

@dlesl dlesl commented May 11, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dlesl
Copy link
Contributor Author

dlesl commented May 11, 2021

More context at #119452. This is a rebar3 plugin that can generate nix expressions for rebar3 projects. It is also intended to replace the rebar3 bootstrap script (but before making that change there's an alternative approach I'd like to investigate in #122633).

Before merging we should tag rebar3_nix and give it a version number, @gleber would 0.1.0 be OK with you?

As an example of how it can be used I've included an updateScript for rebar3.

@gleber
Copy link
Contributor

gleber commented May 11, 2021

Tag created: https://github.com/erlang-nix/rebar3_nix/tree/v0.1.0

@gleber gleber self-requested a review May 11, 2021 21:58
Copy link
Contributor

@gleber gleber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change!

I like this direction more than #122633

@dlesl dlesl force-pushed the init-rebar3-nix branch from 49fde7d to 5854746 Compare May 11, 2021 22:07
@dlesl
Copy link
Contributor Author

dlesl commented May 11, 2021

Thanks, updated to use the tag

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 12, 2021
@dlesl
Copy link
Contributor Author

dlesl commented May 12, 2021

@happysalada I'd like to invite you as a reviewer, not sure how though 🙂

@berbiche berbiche mentioned this pull request May 12, 2021
@happysalada
Copy link
Contributor

@dlesl thanks! I'm not sure how I can help here, but I support the initiative!

@dlesl dlesl force-pushed the init-rebar3-nix branch from 7757819 to d7cca03 Compare May 15, 2021 12:09
@happysalada
Copy link
Contributor

With that one last change that was asked, I will add this on the list of things to merge on monday if somebody doesn't beat me to it.

@dlesl dlesl force-pushed the init-rebar3-nix branch from d7cca03 to c6ac78f Compare May 16, 2021 13:32
@happysalada
Copy link
Contributor

yesterday there was a problem with github, many PRs had the same weird editor config failure. It's transient. When you have a moment, just force push your branch again to trigger the pipeline. The tests will probably run fine.
I can merge when all the tests pass.

@dlesl dlesl force-pushed the init-rebar3-nix branch from c6ac78f to 91f3dea Compare May 17, 2021 06:48
@happysalada happysalada merged commit 34ea3cd into NixOS:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: erlang 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants