Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg_4: 4.3.2 -> 4.4 #122141

Closed
wants to merge 1 commit into from
Closed

ffmpeg_4: 4.3.2 -> 4.4 #122141

wants to merge 1 commit into from

Conversation

vs49688
Copy link
Contributor

@vs49688 vs49688 commented May 8, 2021

Motivation for this change

Updating. This will probably be a big rebuild.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb
Copy link
Contributor

lukegb commented May 8, 2021

@ofborg build ffmpeg_4 ffmpeg_4.passthru.tests

(+darwin)

@lukegb lukegb mentioned this pull request May 8, 2021
@jonringer
Copy link
Contributor

/rebase staging

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2021

Failed to rebase

@jonringer
Copy link
Contributor

This was already done in #118990, it's currently in staging and will be in the next release

@jonringer jonringer closed this May 8, 2021
@lukegb
Copy link
Contributor

lukegb commented May 8, 2021

Hah. Whoops, should've checked staging. Thanks Jon!

@jonringer
Copy link
Contributor

Hah. Whoops, should've checked staging. Thanks Jon!

I only realized it because rebase failed :)

@vcunat
Copy link
Member

vcunat commented May 13, 2021

but darwin fails (in the check you triggered and now on Hydra), so in case you have some ideas...

@vs49688 vs49688 deleted the ffmpeg4 branch November 8, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants