Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulkan: 1.2.162.0 → 1.2.176.0 #122061

Closed
wants to merge 6 commits into from
Closed

Conversation

kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented May 7, 2021

Motivation for this change

Update to the latest sdk version: https://github.com/KhronosGroup/Vulkan-Loader/releases/tag/sdk-1.2.176.0

This includes a change in vulkan-loader to support multiple Vulkan layers with the same name, but different library architectures: KhronosGroup/Vulkan-Loader#525. This can be used by MangoHud & vkBasalt to support 32bit Vulkan layers as a workaround for #101597.

@Ralith @expipiplus1 @zeratax @Atemu

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    I tried this, but ran out of disk space, which is why I'm submitting this to staging. I was able to build my NixOS system with these changes and I haven't noticed any runtime problems.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nativeBuildInputs = [
pkg-config
Copy link
Contributor Author

@kira-bruneau kira-bruneau May 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg-config doesn't seem necssary to build most of these Vulkan projects. Please correct me if I'm wrong.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 122061 at b392cbe run on x86_64-linux 1

40 packages marked as broken and skipped:
  • hydrus
  • libsForQt512.kde-cli-tools
  • libsForQt512.kdenlive
  • libsForQt512.kdeplasma-addons
  • libsForQt512.khotkeys
  • libsForQt512.kinfocenter
  • libsForQt512.kmenuedit
  • libsForQt512.krohnkite
  • libsForQt512.kwin
  • libsForQt512.kwin-dynamic-workspaces
  • ...
215 packages skipped due to time constraints:
  • MIDIVisualizer
  • adapta-gtk-theme
  • adoptopenjdk-icedtea-web
  • ajour
  • anki
  • ankisyncd
  • authenticator
  • blender
  • bottles
  • celluloid
  • ...
40 packages built successfully:
  • libplacebo
  • libretro.atari800
  • libretro.beetle-lynx
  • libretro.beetle-ngp
  • libretro.beetle-vb
  • libretro.beetle-wswan
  • libretro.eightyone
  • libretro.fceumm
  • libretro.fmsx
  • libretro.freeintv
  • libretro.gambatte
  • libretro.gw
  • libretro.handy
  • libretro.meteor
  • libretro.mgba
  • libretro.o2em
  • libretro.opera
  • libretro.prosystem
  • libretro.quicknes
  • libretro.sameboy
  • libretro.smsplus-gx
  • libretro.snes9x2002
  • libretro.snes9x2005
  • libretro.tgbdual
  • libretro.vecx
  • libretro.virtualjaguar
  • mpv
  • mpv-unwrapped
  • mpvScripts.mpris
  • openxr-loader
  • pipewire
  • retroarch
  • retroarchBare
  • vulkan-extension-layer
  • vulkan-headers
  • vulkan-loader
  • vulkan-tools
  • vulkan-tools-lunarg
  • vulkan-validation-layers
  • xdg-desktop-portal-wlr

@kira-bruneau
Copy link
Contributor Author

With this update I've also noticed a slight performance improvement in games with my RX 590 graphics card. Especially with Valheim, which was previously unplayable when launched with Vulkan.

@Ralith
Copy link
Contributor

Ralith commented May 7, 2021

That's probably a coincidence; none of the code updated in this PR is on a hot path, by design.

@kira-bruneau
Copy link
Contributor Author

@Ralith Oh yep sorry, it's definitely a coincidence. I reverted these changes, and I'm still noticing the performance improvements. Maybe from a recent linuxPackages_latest update?

@expipiplus1
Copy link
Contributor

expipiplus1 commented May 8, 2021 via email

@kira-bruneau kira-bruneau mentioned this pull request May 10, 2021
10 tasks
@kira-bruneau
Copy link
Contributor Author

Version 1.2.182.0 was just tagged as a SDK release, but I think it would make sense to handle that in a separate PR.

@expipiplus1 expipiplus1 mentioned this pull request Jul 24, 2021
11 tasks
@expipiplus1
Copy link
Contributor

Thanks! I've opened the 182 bump here: #131299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants