sway: Various improvements (package, module, and documentation) #121925

primeos · 2021-05-06T14:13:22Z

Motivation for this change

Feedback is welcome but unfortunately I don't have that much time for this so concrete changes / actionable feedback would be ideal/preferred (discussions are fine too - I'd just like to avoid updating commits multiple times). It might also make sense to split this into individual PRs but let's see first if there's a need for that.

Note: This isn't tested yet - it's basically an RFC.

Things done

primeos

Added some quick notes (reasons for changes and things that might require a discussion).

nixos/modules/programs/sway.nix

primeos · 2021-05-06T14:17:12Z

nixos/modules/programs/sway.nix

@@ -87,20 +89,35 @@ in {
      type = with types; listOf package;
      default = with pkgs; [
        swaylock swayidle alacritty dmenu
-        rxvt-unicode # For backward compatibility (old default terminal)


Not sure if that requires a release notes entry. It's likely annoying if starting a terminal doesn't work anymore but Sway users will hopefully be skilled enough by figuring this out quickly (e.g. resorting to dmenu).

Maybe we could add a wrapper that launchers alacritty but displays a warning?

I thought about that but not sure if it's a good idea / if a nice implementation is possible (would have to be a graphical warning and then it get's hacky quickly). Do you have something concrete in mind?

You could display a warning in the shell itself: alacritty -e sh -c 'echo WARN; exec $SHELL'

I don't know exactly how you'd make sure the real rxvt-unicode overrides this fake rxvt-unicode.

You could display a warning in the shell itself: alacritty -e sh -c 'echo WARN; exec $SHELL'

That looks and sound super hacky to me (haven't tried if it even works or if exec $SHELL resets the output).
Users could be very confused by this.
And, while I haven't thought about that yet, launching Alacritty for users that expect rxvt-unicode also sounds wrong.
Anyway, if someone ACKs that I'd be ok with that but to me it doesn't really sound like a good idea (the intentions are good but I feel like I'd be super confused).

I don't know exactly how you'd make sure the real rxvt-unicode overrides this fake rxvt-unicode.

There's the lowPrio function ( meta.priority) that should be able to handle that.

Please no, wofi on nixpkgs master segfaults when I run it.

Great, can you get a backtrace and open an issue?

Either way we should add a release notes entry, so people will not be too surprised about this.

How does #127927 look?

Also, wouldn't it be sensible to go with wofi until we have wmenu?

Our programs.sway.extraPackages is "unopinionated", we're simply sticking to the upstream defaults (i.e. Drew's opinion / default configuration). dmenu certainly isn't ideal but is seems like there's still no good enough replacement for it: swaywm/sway#5112

Great, can you get a backtrace and open an issue?

The opposite of great. I was under the impression that we don't push broken packages to solicit bug reports.

Great(, that this problem is so reproducible for you), it would probably help you and others if we could report this issue upstream, hopefully with a backtrace (coredumpctl debug).

primeos · 2021-05-06T14:18:29Z

nixos/modules/programs/sway.nix

+          # To run Qt5 applications natively on Wayland:
+          qt5.qtwayland
+          # Status bars:
+          i3status i3status-rust waybar
+          # Notification daemon:
+          mako
+          # Screenshots
+          grim slurp sway-contrib.grimshot
+          # dmenu replacements:
+          bemenu rofi
+          # Redshift
+          gammastep wlsunset
+          # Alternative terminals:
+          foot termite
+          # Backlight management:
+          brightnessctl light


I guess it's highly debatable what to include here :o We could also leave this empty and maybe install qt5.qtwayland by default?

It's just an example I guess, so don't think this is controversial in any way.

pkgs/applications/window-managers/sway/wrapper.nix

ehmry · 2021-05-12T07:45:54Z

FYI, rxvt-unicode and alacritty are either broken or too expensive to build on aarch64. I have to mask extraPackages in a hardware module because the drivers there only support wayland and the system is unbuildable with those two dependencies.

https://github.com/nix-community/hardware-mnt-reform/blob/241e8c22d994007204de709e58e0c836ae1ec868/flake.nix#L86

primeos · 2021-05-12T21:53:19Z

@ehmry thanks, that's good to know. I plan on dropping rxvt-unicode after the NixOS 21.05 branch-off as we shouldn't keep it around forever. alacritty should remain part of the default though as it's used by Sway's default configuration (which should work out of the box for new users). But we've intentionally used extraPackages for this so that it can be customized easily.

Anyway, if alacritty isn't build on Hydra for AArch64 that seems like something we should change. It already seems to be build at least for nixpkgs-unstable (https://hydra.nixos.org/job/nixpkgs/trunk/alacritty.aarch64-linux and nixos-20.09: https://hydra.nixos.org/job/nixos/release-20.09-aarch64/nixpkgs.alacritty.aarch64-linux) but I didn't find it in the nixos:trunk-combined jobset (nixos-unstable).

ehmry · 2021-05-13T08:41:12Z

Maybe it will build again for awhile, but I'm wary of my system depending on anything written in rust.

This was done only for backward compatibility and is not required by the default configuration anymore. Unfortunately this might be a breaking change for some users.

stale · 2022-01-06T02:24:51Z

I marked this as stale due to inactivity. → More info

github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 6, 2021

primeos commented May 6, 2021

View reviewed changes

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels May 6, 2021

primeos mentioned this pull request May 11, 2021

sway: Set XDG_CURRENT_DESKTOP=sway #122602

Merged

10 tasks

primeos added 2 commits May 15, 2021 21:31

nixos/sway: Stop installing rxvt-unicode by default

a268b5a

This was done only for backward compatibility and is not required by the default configuration anymore. Unfortunately this might be a breaking change for some users.

nixos/sway: Update the extraPackages examples

dd97746

primeos force-pushed the sway-improvements branch from f65815a to dd97746 Compare May 15, 2021 19:32

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels May 15, 2021

primeos mentioned this pull request May 27, 2021

sway: Optimal NixOS integration #57602

Open

22 tasks

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 6, 2022

wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024

wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sway: Various improvements (package, module, and documentation) #121925

sway: Various improvements (package, module, and documentation) #121925

primeos commented May 6, 2021

primeos left a comment

primeos May 6, 2021

Synthetica9 May 6, 2021

primeos May 6, 2021

Synthetica9 May 6, 2021

primeos May 6, 2021

ehmry Jun 23, 2021

mweinelt Jun 23, 2021

primeos Jun 23, 2021

ehmry Jun 23, 2021

mweinelt Jun 23, 2021

primeos May 6, 2021

Mindavi May 6, 2021

ehmry commented May 12, 2021

primeos commented May 12, 2021

ehmry commented May 13, 2021

stale bot commented Jan 6, 2022

sway: Various improvements (package, module, and documentation) #121925

Are you sure you want to change the base?

sway: Various improvements (package, module, and documentation) #121925

Conversation

primeos commented May 6, 2021

Motivation for this change

Things done

primeos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ehmry commented May 12, 2021

primeos commented May 12, 2021

ehmry commented May 13, 2021

stale bot commented Jan 6, 2022