-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jre_minimal: add basic test #121043
jre_minimal: add basic test #121043
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good starting point for testing the correctness of jre_minimal
. And I'd be happy to merge it.
Perhaps this is the wrong place to ask, but what about its validity? I couldn't find a use for jre_minimal
. For instance, openapi-generator-cli
needed some xml-related module.
If we don't have a practical application for jre_minimal
, this is still a useful smoke test for Nixpkgs' jlink glue. In that case we should make the purpose clear though.
aed23d0
to
197d953
Compare
Indeed I think it should not be used inside of nixpkgs itself, but be available for easy access to the 'jlink glue' for more "closed-world" downstream projects. I've added a test showing that off and amended it to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha! It didn't occur to me that you could override the set of modules. It's documented in the manual though, so 👍 .
More than enough reason to include these tests. Just one nitpick and this is good to go.
pkgs/development/compilers/openjdk/tests/test_jre_minimal_with_logging.nix
Outdated
Show resolved
Hide resolved
197d953
to
b21d1ae
Compare
Thanks! |
Motivation for this change
Adds a very basic test for jre_minimal.
This is a rather crude starting point, I'd welcome feedback!
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)