Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracy: force-disable LTO for darwin #118611

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Apr 5, 2021

Motivation for this change

Appears to have been broken for a while, perhaps since upstream enabled LTO for macos builds. Anyway, just means we have to work around #19098

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 5, 2021

Result of nixpkgs-review pr 118611 at 59d8cd8 run on x86_64-linux 1

1 package built successfully:
  • tracy
3 suggestions:
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/development/tools/tracy/default.nix:29:3:

       |
    29 |   buildPhase = ''
       |   ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/tools/tracy/default.nix:36:3:

       |
    36 |   installPhase = ''
       |   ^
    
  • warning: fixup-phase

    fixupPhase should not be overridden, use postFixup instead.

    Near pkgs/development/tools/tracy/default.nix:43:3:

       |
    43 |   fixupPhase = lib.optionalString stdenv.isDarwin ''
       |   ^
    

Result of nixpkgs-review pr 118611 at 59d8cd8 run on aarch64-linux 1

1 package built successfully:
  • tracy

@SuperSandro2000
Copy link
Member

Please change fixupPhase to postFixup.

@SuperSandro2000 SuperSandro2000 merged commit a64eb90 into NixOS:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants