Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "pythonPackages.pandas: skip hanging/crashing test" #118531

Merged
merged 1 commit into from
Apr 5, 2021
Merged

Revert "pythonPackages.pandas: skip hanging/crashing test" #118531

merged 1 commit into from
Apr 5, 2021

Conversation

SuperSandro2000
Copy link
Member

This reverts commit b86327e.

This is a temporary hack which can't be merged into master at some point
because the package is actually broken. The real issue will likely be fixed
in #118454.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Revert "pythonPackages.pandas: skip hanging/crashing test"
3e6464e 
This reverts commit b86327e.

This is a temporary hack which can't be merged into master at some point
because the package is actually broken. The real issue will likely be fixed
in NixOS#118454.
@ofborg ofborg bot requested review from 7c6f434c and knedlsepp April 5, 2021 01:55
@SuperSandro2000 SuperSandro2000 merged commit a035be2 into NixOS:staging Apr 5, 2021
@SuperSandro2000 SuperSandro2000 deleted the remove-pandas-hack branch April 5, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SuperSandro2000