Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgsStatic: apply stdenvAdapters to all llvm stdenvs #118313

Merged
merged 1 commit into from
Apr 28, 2021
Merged

pkgsStatic: apply stdenvAdapters to all llvm stdenvs #118313

merged 1 commit into from
Apr 28, 2021

Conversation

sternenseemann
Copy link
Member

Motivation for this change

Note that I haven't really been able to test this change yet, any hints on good starting points would be appreciated.
This has probably little impact on nixpkgs itself as the llvm stdenvs are rarely used, but may be useful for downstream
users.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 2, 2021
sternenseemann added a commit to openlab-aux/flipdot-gschichtler that referenced this pull request Apr 18, 2021
@sternenseemann
feat(warteraum-static): build using clang
1bc494f 
Using the default version since the versioned llvm stdenvs don't have
the static adapters applied: NixOS/nixpkgs#118313
@sternenseemann sternenseemann mentioned this pull request Apr 20, 2021
Open
@Ericson2314
Copy link
Member

Ericson2314 commented Apr 28, 2021 •
edited
Loading

Yeah this is good. I do want to get rid of the overlay but this is no worse for now.

@Ericson2314 Ericson2314 merged commit 3f3f831 into NixOS:master Apr 28, 2021
@sternenseemann sternenseemann deleted the static-llvm-stdenvs branch April 28, 2021 11:20
@sternenseemann sternenseemann restored the static-llvm-stdenvs branch July 24, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sternenseemann @Ericson2314