Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Updates #114895

Merged
merged 3 commits into from
Mar 3, 2021
Merged

Small Updates #114895

merged 3 commits into from
Mar 3, 2021

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Mar 2, 2021 •
edited
Loading

Motivation for this change
Things done

grc: 1.12 -> 1.13
udiskie: 2.2.0 -> 2.3.2
stella: 6.5.1 -> 6.5.2

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Mar 2, 2021
@ofborg ofborg bot requested review from lovek323 and peterhoeg March 2, 2021 21:41
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 2, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 2, 2021 •
edited
Loading

Result of nixpkgs-review pr 114895 at 7a6be9d run on x86_64-linux 1

3 packages built:

Result of nixpkgs-review pr 114895 at 7a6be9d run on aarch64-linux 1

3 packages built:

@AndersonTorres
Copy link
Member Author

How can I call this bot directly?

@SuperSandro2000
Copy link
Member

How can I call this bot directly?

You can't. @rmcgibbo

@SuperSandro2000 SuperSandro2000 merged commit 58927de into NixOS:master Mar 3, 2021
@rmcgibbo
Copy link
Contributor

rmcgibbo commented Mar 3, 2021

It's on my TODO list. Is that an important feature for you?

@AndersonTorres
Copy link
Member Author

No, it isn't. This was mostly out of curiousity.

Do the bot automatically runs after a commit update, like the ofborg?

@SuperSandro2000
Copy link
Member

Do the bot automatically runs after a commit update, like the ofborg?

It only runs once if not other nixpkgs-review was run for that platform.

@rmcgibbo rmcgibbo mentioned this pull request May 4, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovek323 lovek323 Awaiting requested review from lovek323

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndersonTorres @r-rmcgibbo @SuperSandro2000 @rmcgibbo