Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin.bootstrap_cmds: update to 121 #109052

Merged
merged 2 commits into from
Feb 1, 2021
Merged

darwin.bootstrap_cmds: update to 121 #109052

merged 2 commits into from
Feb 1, 2021

Conversation

holymonson
Copy link
Contributor

Motivation for this change

We need to update bootstrap_cmds first, because it blocks updating xnu, which blocks updating Libsystem.

This PR is blocked by #108590.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild labels Jan 12, 2021
@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 18, 2021
@holymonson holymonson marked this pull request as ready for review January 23, 2021 15:45
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-linux: 1-10 labels Jan 23, 2021
@holymonson holymonson force-pushed the bootstrap_cmds branch 2 times, most recently from 86b3bec to 4be9a24 Compare January 27, 2021 10:38
@holymonson holymonson requested review from siraben and veprbl January 27, 2021 10:41
@ofborg ofborg bot added 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 27, 2021
@veprbl veprbl changed the title darwin.bootstrap_cmds: update to 121-macos-11.0.1 darwin.bootstrap_cmds: update to 121 Jan 28, 2021
@holymonson holymonson requested a review from veprbl January 29, 2021 07:57
@holymonson
Copy link
Contributor Author

@ofborg eval

@veprbl veprbl merged commit 98cc48e into NixOS:staging Feb 1, 2021
@holymonson holymonson deleted the bootstrap_cmds branch February 1, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siraben siraben siraben left review comments

@veprbl veprbl veprbl approved these changes

@LnL7 LnL7 Awaiting requested review from LnL7

@gridaphobe gridaphobe Awaiting requested review from gridaphobe

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@shlevy shlevy Awaiting requested review from shlevy

@copumpkin copumpkin Awaiting requested review from copumpkin

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
Staging
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@holymonson @veprbl @siraben @SuperSandro2000