Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: add nativeBuildInputs for extra build tools #108950

Closed
wants to merge 1 commit into from
Closed

linux: add nativeBuildInputs for extra build tools #108950

wants to merge 1 commit into from

Conversation

kloenk
Copy link
Member

@kloenk kloenk commented Jan 10, 2021

Motivation for this change

Create a way to add extra BuildInputs into buildLinux, so linux forks which need extra tools to build linux can use those

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kloenk kloenk force-pushed the linux-extraPackages branch from 67e57c9 to 576a87a Compare January 10, 2021 14:30
@kloenk
Copy link
Member Author

kloenk commented Jan 10, 2021

I removed extraBuildInputs, as the probably are not needed, and renamed it to nativeBuildInputs

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 10, 2021 •
edited by cole-h
Loading

@ofborg eval

@SuperSandro2000
Copy link
Member

not sure why this fails.

@cole-h cole-h mentioned this pull request Jan 11, 2021
Merged
14 tasks
@kloenk
Copy link
Member Author

kloenk commented Jan 11, 2021

rebased, so OfBorg no hopefully can eval

@kloenk kloenk force-pushed the linux-extraPackages branch from 576a87a to c3b8f9d Compare January 11, 2021 11:02
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 11, 2021 •
edited
Loading

Rebasing makes no difference. I think staging eval is broken right now. Lets wait until that is resolved.

@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 18, 2021
@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@Artturin Artturin changed the title linux: add extraBuildInputs and extraNativeBuildInputs linux: add extraNativeBuildInputs Oct 16, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 16, 2021
@github-actions github-actions bot added the 6.topic: kernel The Linux kernel label Oct 16, 2021
@Artturin Artturin mentioned this pull request Oct 16, 2021
Closed
@Artturin Artturin changed the title linux: add extraNativeBuildInputs linux: add nativeBuildInputs Oct 16, 2021
@Artturin Artturin force-pushed the linux-extraPackages branch from c3b8f9d to ddf902d Compare October 16, 2021 23:53
@github-actions github-actions bot added 6.topic: emacs Text editor 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: ocaml 6.topic: python 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Oct 16, 2021
@github-actions github-actions bot added the 8.has: module (update) This PR changes an existing module in `nixos/` label Oct 16, 2021
@Artturin Artturin changed the base branch from staging to master October 16, 2021 23:54
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: lua 6.topic: emacs Text editor 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: changelog 6.topic: ocaml labels Oct 16, 2021
@Artturin Artturin changed the title linux: add nativeBuildInputs linux: add nativeBuildInputs for extra build tools Oct 16, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 17, 2021
@kloenk kloenk closed this Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: kernel The Linux kernel 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kloenk @SuperSandro2000