Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binutils: 2.34 -> 2.35.1 #108453

Merged
merged 1 commit into from
Jan 10, 2021
Merged

binutils: 2.34 -> 2.35.1 #108453

merged 1 commit into from
Jan 10, 2021

Conversation

lovesegfault
Copy link
Member

Motivation for this change

Since we finally succeeded at bumping to 2.34, this is the bump to 2.35(.1).
Having run some tests locally, this seems much less eventful, thankfully, than
the last one.

The only change I had to do was remove the no-plugins patch, which no longer
applied. Looking at the source of 2.35.1 I think the patch is no longer
necessary, but would like a second opinion / confirmation here as I'm not 100%
on what the patch was even for in the first place.

cc. @FRidh @luc65r @flokli @pbogdan @thefloweringash

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh added this to the 21.03 milestone Jan 10, 2021
@FRidh FRidh merged commit 306aefd into NixOS:staging Jan 10, 2021
@FRidh
Copy link
Member

FRidh commented Jan 10, 2021

The only change I had to do was remove the no-plugins patch, which no longer
applied. Looking at the source of 2.35.1 I think the patch is no longer
necessary, but would like a second opinion / confirmation here as I'm not 100%
on what the patch was even for in the first place.

No idea, but let's find out whether it causes any trouble.

@nh2
Copy link
Contributor

nh2 commented Jul 6, 2021

This upgrade caused a 300x regression in strip performance, making it take minutes instead of seconds:

#129467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants