-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.python-prctl: disabled tests causing build failure #106875
pythonPackages.python-prctl: disabled tests causing build failure #106875
Conversation
1a59269
to
47edd37
Compare
Looks good besides the comment nitpick. |
@catern Oh sorry about that, I'll update that. Thank you 😄 |
47edd37
to
cfefa5c
Compare
Result of 3 packages built:
|
cfefa5c
to
0f75b2b
Compare
Now disables tests using pytestCheckHook + disabledTests instead of patch file. Disables: - test_speculation_ctrl - test_mpx Enables: - test_mce_kill - test_proctitle
0f75b2b
to
d29570f
Compare
@ofborg eval |
Those tests no longer fail in 1.8.1. |
@SuperSandro2000 This commit was based on failures found in version 1.8.1. I just tried the latest version of master, and they're still failing for me:
|
I'm reopening this because this is still broken on hydra, and has been broken since 2020-12-06: https://hydra.nixos.org/build/139366147. |
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 3 packages built:
The following issues got detected with the above build packages.
python37Packages.python-prctl:
warning: unclear-gpl Near pkgs/development/python-modules/python-prctl/default.nix:39:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md |
Motivation for this change
Fixes #106871
Now disables tests using pytestCheckHook + disabledTests instead of patch file.
Disables:
Enables:
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)No binary files, package is library
nix path-info -S
before and after)@catern