Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustup: 1.22.1 -> 1.23.1 #106443

Merged
merged 1 commit into from
Dec 9, 2020
Merged

rustup: 1.22.1 -> 1.23.1 #106443

merged 1 commit into from
Dec 9, 2020

Conversation

eddyb
Copy link
Contributor

@eddyb eddyb commented Dec 9, 2020

Motivation for this change

The 1.23.0 release added support for TOML format rust-toolchain, which projects are starting to take advantage of.
On older rustup versions, the new TOML rust-toolchain will always cause errors and has to be changed/removed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eddyb eddyb mentioned this pull request Dec 9, 2020
Closed
@ofborg ofborg bot requested a review from Mic92 December 9, 2020 13:16
@yorickvP
Copy link
Contributor

yorickvP commented Dec 9, 2020

@GrahamcOfBorg build rustup

@Mic92
Copy link
Member

Mic92 commented Dec 9, 2020

Result of nixpkgs-review pr 106443 run on x86_64-linux 1

1 package built:
  • rustup

@Mic92 Mic92 merged commit de8b289 into NixOS:master Dec 9, 2020
@eddyb eddyb deleted the rustup-1.23.1 branch December 9, 2020 16:29
@eddyb eddyb mentioned this pull request Dec 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorickvP yorickvP yorickvP approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eddyb @yorickvP @Mic92