python: Propagate packageOverrides to pythonForBuild #105113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As follow-up of #104201 I think it would be good if we get rid of passing around |
10 tasks
FRidh
added a commit
to FRidh/nixpkgs
that referenced
this pull request
Nov 28, 2020
Follow-up to NixOS#104201, related to NixOS#105113.
When overriding versions of build tools injected via hooks `packageOverrides` was not taken into account and 2 incompatible versions of the same package (`wheel` in this case) ended up in the closure, causing the builds to fail.
adisbladis
force-pushed
the
pythonforbuild-overrides
branch
from
dfb170f to
49b8738
Compare
|
Have you tested again without this change on master? |
|
@FRidh Yes I have. |
|
Alright. It would be nice to communicate that before merging this yourself.
@Ericson2314 seems like, while splicing is now fixed, overrides are not yet taken into account. We'll need to make a test for this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When overriding versions of build tools injected via hooks by
pythonForBuildpackageOverrideswas not taken into account and 2 incompatibleversions of the same package (
wheelin this case) ended up in theclosure, causing the builds to fail.
This was broken by b57c5d4.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)