qt515.qtwebkit: unbreak

[doronbehar]

Motivation for this change

More qt515 fixes (like #102840) with unbroken qt515.qtwebkit.

Here's a git grep list of packages that use qt514 in all-packages.nix. Ideally each of them needs to have at least a comment explaining why it uses qt514 and not qt515. Usually they are pinned to qt514 since qt515.qtwebkit is broken on master, but not on this branch - hence every package listed here likely can use qt515.

• digitalbitbox - has a comment regarding qt514 (segfaults with qt515).
• apitrace
• brewtarget (@mmahut)
• calamares (@manveru)
• clementine - has a comment regarding qt514 (for the next update)
• mellowplayer (@kalbasit)
• dsview (@bachp)
• fontmatrix
• hal-hardware-analyzer (@risicle)
• heaptrack (@gebner) - already fixed in heaptrack: migrate to Qt5.15 #104442
• i-score (@magnetophon)
• iannix (@freezeboy)
• partition-manager (@peterhoeg)
• ksmoothdock (@SCOTT-HAMILTON)
• kstars (@TimPut)
• nixnote2 (@htr)
• nmapsi4 (@peterhoeg)
• olive-editor (@balsoft)
• owncloud-client (@qknight)
• qownnotes (@dtzWill)
• qtikz
• rosegarden (@lebastr)
• subsurface (@mguentner)
• teamviewer (@jagajaga)
• texworks (@dotlambda)
• wkhtmltopdf (@jb55)
• colmap (@lebastr)
• nextpnr (@thoughtpolice @emilazy)
• supercollider (@MrMebelMan)
• phantomjs2 (@aflatter)
• qtcreator (@akaWolf)
• herqq
• qolibri
• qgnomeplatform - should be handled in Move some qt5 style packages to qt5-packages.nix #102594 .
• vtk_9 (@tfmoraes)
• qmc2
• zeal (@svenkeidel @peterhoeg)
• antimony (@rnhmjoj)
• in
• bibletime
• calligra (@Phreedom @ebzzry @zraexy)
• cb2bib (@edwtjo)
• copyq (@willtim)
• dfilemanager
• drawpile (@fgaz)
• drawpile-server-headless
• evilpixie (@fgaz)
• ghostwriter (@dotlambda)
• goldendict (@gebner @astsmtl @sikmir) - fixed in goldendict: 2020-05-27 -> 2020-12-09 #106774
• gqrx - should be handled in gnuradio: rewrite #99685 .
• mindforger
• multibootusb
• gpsbabel (@rycee)
• gpsbabel-gui (@sikmir)
• inspectrum - should be handled in gnuradio: rewrite #99685 .
• ipe (@ttuegel)
• kdevelop-pg-qt
• kdevelop-unwrapped (@ambrop72)
• kdev-php (@aanderse)
• kdev-python
• kexi (@zraexy)
• kotatogram-desktop (@ilya-fedin)
• krusader (@sander @turion)
• kvirc (@suhr)
• librecad (@Kiwi @viric)
• libreoffice (@7c6f434c)
• lsd2dsl (@sikmir)
• mapmap (@erictapen)
• mendeley (@dtzWill)
• merkaartor
• p4v (@nathyong @nioncode)
• polyphone (@Maxdamantus)
• shotcut (@cillianderoiste @woffs @peti)
• smtube (@vbgl)
• mythtv (@titanous)
• notepadqq (@rszibele)
• obs-ndi (@peti @jshcmbll)
• pulseview (@bjornfor)
• in
• qlandkartegt (@sikmir)
• qmapshack (@dotlambda @sikmir)
• qsyncthingtray
• quiterss (@primeos)
• falkon (@peterhoeg)
• rapcad (@7c6f434c)
• rclone-browser (@dotlambda)
• rpcs3 (@abbradar @nocent)
• rstudio (@ehmry @changlinli @ciil)
• sayonara (@deepfire)
• scantailor-advanced (@jfrankenau)
• scribusUnstable (@erictapen @Kiwi)
• seafile-client
• swift-im (@orivej)
• toggldesktop (@yegortimoshenko)
• tony (@orivej)
• trojita (@ehmry)
• valentina (@jfrankenau)
• qpdfview (@7c6f434c)
• virtualbox (@svanderburg)
• vlc
• wpsoffice (@Ninlives @Th0rgal)
• xygrib (@SuperSandro2000 @johannesloetzsch)
• zanshin (@zraexy)
• zombietrackergps (@Sohalt)
• bitcoin-unlimited (@DmitryTsygankov)
• bitcoin-classic (@jefdaj)
• bitcoin-gold (@mmahut)
• digibyte (@mmahut)
• litecoin (@offlinehacker)
• vertcoin (@mmahut)
• digikam
• hedgewars (@kragniz @fpletz)
• solarus
• solarus-quest-editor
• apmplanner2 (@wucke13)
• mame (@gnidorah)
• wacomtablet (@Thra11)
• golden-cheetah (@ocharles)

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[doronbehar]

cc @freezeboy for review.

[freezeboy]

Looks good to me

[FRidh]

konversation: 1.7.5 -> 1.7.5

Should be 1.7.7.

[doronbehar]

Should be 1.7.7.

Fixed.

[ttuegel]

I updated the top comment to ping the relevant maintainers.

Please test your packages with Qt 5.15, and un-pin them from Qt 5.14 if everything is working. (Note: this will probably not be possible for proprietary applications.)

[turion]

Does that mean we should use libsForQt5 or libsForQt515? Probably libsForQt5 is better?

[freezeboy]

Yes better to use the generic version to avoid the same problem with many programs pinned to 5.15 when the default qt5 will be updated

[fgaz]

evilpixie waiting on upstream: bcampbell/evilpixie#14 done in #108215

[dotlambda]

There seems to be a limit to the number of people you can ping in a message. We should remove the maintainer ping for the packages that have already been fixed.