libmtp, libgphoto2, gphoto2: Switch to Github, allow building from repo #104000
Conversation
Github is where upstream's development happens now, and building from repo makes adding patches and overriding the commit easier. Also use pname+version, see NixOS#103997.
Github is where upstream's development happens now, and building from repo makes adding patches and overriding the commit easier. Also use pname+version, see NixOS#103997.
Github is where upstream's development happens now, and building from repo makes adding patches and overriding the commit easier. Also use pname+version, see NixOS#103997.
|
cc @jcumming |
| @@ -33,8 +48,6 @@ stdenv.mkDerivation rec { | |||
| MTP, and other vendor specific protocols for controlling and transferring data | |||
| from digital cameras. | |||
| ''; | |||
| version = "2.5.23"; | |||
| tag = "libgphoto2-2_5_23-release"; | |||
| # XXX: the homepage claims LGPL, but several src files are lgpl21Plus | |||
There was a problem hiding this comment.
What does the XXX: mean?
There was a problem hiding this comment.
It's a way to indicate a sort of TODO or ugliness note, but I don't think it's good, exactly because it isn't obvious what it means.
There was a problem hiding this comment.
I recognized the writing style as mine, but I didn't remember writing that comment.
Git blame claims I wrote it 8 years ago!
The upstream project now reports: GNU Lesser General Public License v2.1. Let's use that.
There was a problem hiding this comment.
@jcumming Unfortunately, the GitHub license detector is not able to determine if the license is *gpl-or-later or *gpl-only, see https://discourse.nixos.org/t/lib-licenses-gpl3-co-are-now-deprecated/8206 for more details.
There was a problem hiding this comment.
I'll leave it to you people to figure that one out 😁
Beyond that, anybody mind approving if it looks good?
Motivation for this change
Github is where upstream's development happens now,
and building from repo makes adding patches and overriding the commit easier.
Also use pname+version, see #103997, and reformat for reduced merge conflicts.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)