Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awscli2: fix completion #103718

Merged
merged 1 commit into from
Nov 23, 2020
Merged

awscli2: fix completion #103718

merged 1 commit into from
Nov 23, 2020

Conversation

qrevel
Copy link
Contributor

@qrevel qrevel commented Nov 13, 2020

Generate index file for shell completion

Fix #103709

See-also: https://github.com/Homebrew/homebrew-core/pull/57547/files

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from bhipple November 13, 2020 16:32
@davegallant davegallant mentioned this pull request Nov 21, 2020
Merged
10 tasks
FRidh
FRidh requested changes Nov 21, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid merges, rebase instead and squash the commits.

@FRidh
Copy link
Member

FRidh commented Nov 21, 2020

Other than that, the change looks good to me. I am however unfamiliar with installing completions.

@qrevel qrevel force-pushed the fix-aws-cli-completion branch from 44226ec to 54871c4 Compare November 21, 2020 09:54
@qrevel
Copy link
Contributor Author

qrevel commented Nov 21, 2020

Avoid merges, rebase instead and squash the commits.

Thx @FRidh for letting me know of the git strategy, I've squashed the commits.

@qrevel qrevel requested a review from FRidh November 21, 2020 09:56
@peterhoeg
Copy link
Member

Tested - works!

@peterhoeg peterhoeg merged commit 8582f5d into NixOS:master Nov 23, 2020
@qrevel qrevel deleted the fix-aws-cli-completion branch December 23, 2020 18:07
@jdelStrother jdelStrother mentioned this pull request Mar 18, 2021
Closed
10 tasks
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple Awaiting requested review from bhipple

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

awscli2 completion is broken
4 participants
@qrevel @FRidh @peterhoeg @Janik-Haag