python3Packages.ovito: 3.0.0 -> 3.3.1

[prusnak]

Motivation for this change

Version update, convert to Python 3 (part of #101964), fix build

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[jonringer]

I would much rather have the python interpreter parameterized

in all-packages, i would would just do python = python3;

[jonringer]

do you mind squashing?

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits.

This can be done without git rebase -i by doing:

git reset HEAD~1                    # move fix-up commits into unstaged
git add -- pkgs/                    # move changes into staged
git commit --amend --no-edit        # add changes to previous commit
git push ... ... --force            # modify current PR branch

However, git rebase -i is a more powerful alternative, I created a small video demonstrating it's use here. A more indepth text tutorial can be found here

[prusnak]

do you mind squashing?

I am squashing it at the moment. Easiest thing how to accept your suggestions in my local branch is to accept them via Github UI into remote branch and then update my local branch.

[prusnak]

in all-packages, i would would just do python = python3;

What do you mean by this? This changeset does not touch all-packages ...

I guess you meant this, right? (in pkgs/top-level/python-packages.nix - included in 574c7d9)

-  ovito = toPythonModule (pkgs.libsForQt5.callPackage ../development/python-modules/ovito { });
+  ovito = toPythonModule (pkgs.libsForQt5.callPackage ../development/python-modules/ovito { inherit python; });

[jonringer]

sorry, for some reason I thought there was a top-level ovito

[jonringer]

oh in the original list, it just shows ovito, but that's likely because it's just taking the derivation name.

[jonringer]

LGTM

Result of nixpkgs-review pr 102250 1

3 packages built:

• python27Packages.ovito
• python37Packages.ovito
• python38Packages.ovito