-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tvm: init at 0.7.0 #101728
tvm: init at 0.7.0 #101728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds on darwin. Some quick suggestions but otherwise LGTM. Oh, and remember to fixup your commits before merging.
@r-burns Feedback addresses, commits fixed up :-) |
This looks good to me! Builds fine on my linux box. |
Run on darwin: Result of 1 package built:
|
228004a
to
85fe30e
Compare
@sikmir Are you able to merge this? |
I'm only maintainer, not a commiter. |
Result of 1 package built:
|
@SuperSandro2000 Good for merge? :D |
@adelbertc please squash the commit. After that it can be merged. |
Result of 1 package built:
|
@SuperSandro2000 done! |
@SuperSandro2000 Any love? :D |
Result of 1 package built:
|
Result of 1 package built:
|
@SuperSandro2000 Thank you!! 🙏 |
Motivation for this change
New package: TVM, An End to End Deep Learning Compiler Stack for CPUs, GPUs and accelerators.
cc @imalsogreg @tkonolige
Things done
sandbox
innix.conf
on non-NixOS linux) <-- does this work on Darwin ATM? It didn't last time I checked.nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
) <-- None, shared headers and library onlynix path-info -S
before and after)Result of a Nix build