-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: python setup.py test
is deprecated
#71897
Labels
Milestone
Comments
stale
bot
added
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Aug 4, 2020
10 tasks
stale
bot
removed
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Nov 1, 2020
From what I've seen (very subjective), most packages are moving to either tox or pytest (without tox). The choice should be detectable with a few checks in the default checkPhase. For all others we could omit a warning requesting customization of the checkPhase. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The
test
command ofsetuptools
has been deprecated. Packages should stop using it, we should stop using it as a defaultcheckPhase
.Additional context
The command is currently used as the default
checkPhase
. It was not uncommon that we had to set a customcheckPhase
, typicallypytest
ornosetests
. Now that the command is being deprecated/removed, we can expect more variation in commands to be used. Upstream does encourage the use oftox
, although I think we should generally avoid it because it's a relatively heavy. (OK, not very heavy, but because it has Python deps we can't use it for core packages because of the DAG)Related
The text was updated successfully, but these errors were encountered: