Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge generic and manual kernel config builds #1389

Closed
shlevy opened this issue Dec 16, 2013 · 3 comments
Closed

Merge generic and manual kernel config builds #1389

shlevy opened this issue Dec 16, 2013 · 3 comments
Assignees
@shlevy
Milestone
14.04

Comments

@shlevy
Copy link
Member

shlevy commented Dec 16, 2013

Currently we have two expressions that both build the kernel, whose only interface differences are in whether or not the .config is generated or provided. These builds should be merged with the two different interfaces simply being two ways to call the same underlying function, reducing code duplication and allowing the generic kernel builds to benefit from the IMO better structure of the newer manual kernel builds.
@ghost ghost assigned shlevy Dec 16, 2013
@edolstra
Copy link
Member

+1 on getting rid of duplication

What is the "better structure"?

@shlevy
Copy link
Member Author

shlevy commented Dec 16, 2013

Structure may have been the wrong word, but the manual kernel build uses multiple outputs (suboptimally currently, which was part of the problem with the old PR) and uses the official kernel build system for building and installing, while the generic one (last I checked) had a manually maintained shell script to handle the install and parts of the build.

@shlevy
Copy link
Member Author

shlevy commented Jan 5, 2014

Fixed by 139f894

@shlevy shlevy closed this as completed Jan 5, 2014
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Dec 8, 2019
@mweinelt
weechat: 2.6 -> 2.7
d1cb8bf 
Disables support for Javascript and PHP:
- Javascript requires an old version of v8
- PHP requires a larger number of dependencies in addition to php-embed

Changelog [1]:

  New features
    - core: add option weechat.look.nick_color_hash_salt to shuffle nick colors (issue NixOS#635)
    - core: add different icons sizes (16x16 to 512x512) (issue NixOS#1347)
    - core: add file weechat.desktop
    - core: add reverse of string for screen in evaluation of expressions with "revscr:"
    - core: add length of string (number of chars and on screen) in evaluation of expressions with "length:xxx" and "lengthscr:xxx"
    - core: add calculation of expression in evaluation of expressions with "calc:xxx" (issue NixOS#997)
    - core: add optional default path (evaluated) in completion "filename"
    - core: add support of modifiers in evaluation of expressions with "modifier:name,data,string"
    - api: add modifier "color_encode_ansi" (issue NixOS#528)
    - api: add modifier "eval_path_home"
    - irc: add filters on raw buffer (issue NixOS#1000)
    - irc: add option irc.look.display_pv_warning_address to display a warning in private buffer if the remote nick address has changed (issue NixOS#892)
    - irc: add server option "ssl_password" (issue NixOS#115, issue NixOS#1416)
    - irc: add "user" in output of irc_message_parse (issue NixOS#136)
    - irc: add options irc.color.message_kick and irc.color.reason_kick (issue NixOS#683, issue NixOS#684)
    - logger: add option logger.file.color_lines (issue NixOS#528, issue NixOS#621)
    - script: add options "-ol" and "-il" in command "/script list" to send translated string with list of scripts loaded, display "No scripts loaded" if no scripts are loaded
    - xfer: add option xfer.file.download_temporary_suffix with default value ".part" (issue NixOS#1237)

  Bug fixes
    - core: set buffer name, short name and title only if the value has changed
    - core: fix scrolling up in bare mode when switched to bare mode at the top of the buffer (issue NixOS#899, issue NixOS#978)
    - core: optimize load of configuration files
    - core: fix window separators not respecting window splits (issue NixOS#630)
    - core: fix cursor mode info when prefix_align is none and with words split across lines (issue NixOS#610, issue NixOS#617, issue NixOS#619)
    - core: add support of reverse video in ANSI color codes
    - core: fixed segfault during excessive evaluation in function string_repeat (issue NixOS#1400)
    - buflist: fix extra spaces between buffers when conditions are used to hide buffers (regression introduced in version 2.6) (issue NixOS#1403)
    - irc: do not automatically open a channel with name "0" (issue NixOS#1429)
    - irc: remove option irc.network.channel_encode, add server option "charset_message" to control which part of the IRC message is decoded/encoded to the target charset (issue NixOS#832)
    - irc: use path from option xfer.file.upload_path to complete filename in command "/dcc send" (issue NixOS#60)
    - logger: fix write in log file if it has been deleted or renamed (issue NixOS#123)
    - python: send "bytes" instead of "str" to callbacks in Python 3 when the string is not UTF-8 valid (issue NixOS#1389)
    - relay: send message "_buffer_title_changed" to clients only when the title is changed
    - xfer: fix memory leak when a xfer is freed and when the plugin is unloaded

  Tests
    - unit: add tests on GUI color functions

  Build
    - core: fix build on Haiku (issue NixOS#1420)
    - core: fix build on Alpine
    - core: remove file FindTCL.cmake
    - core: display an error on missing dependency in CMake (issue NixOS#916, issue NixOS#956)
    - debian: disable Javascript plugin on Debian Sid and Ubuntu Eoan
    - debian: build with Guile 2.2
    - guile: add support of Guile 2.2, disable /guile eval (issue NixOS#1098)
    - python: add detection of Python 3.8

[1] https://weechat.org/files/changelog/ChangeLog-2.7.html
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this issue Dec 10, 2019
@mweinelt @dtzWill
weechat: 2.6 -> 2.7
4a83939 
Disables support for Javascript and PHP:
- Javascript requires an old version of v8
- PHP requires a larger number of dependencies in addition to php-embed

Changelog [1]:

  New features
    - core: add option weechat.look.nick_color_hash_salt to shuffle nick colors (issue NixOS#635)
    - core: add different icons sizes (16x16 to 512x512) (issue NixOS#1347)
    - core: add file weechat.desktop
    - core: add reverse of string for screen in evaluation of expressions with "revscr:"
    - core: add length of string (number of chars and on screen) in evaluation of expressions with "length:xxx" and "lengthscr:xxx"
    - core: add calculation of expression in evaluation of expressions with "calc:xxx" (issue NixOS#997)
    - core: add optional default path (evaluated) in completion "filename"
    - core: add support of modifiers in evaluation of expressions with "modifier:name,data,string"
    - api: add modifier "color_encode_ansi" (issue NixOS#528)
    - api: add modifier "eval_path_home"
    - irc: add filters on raw buffer (issue NixOS#1000)
    - irc: add option irc.look.display_pv_warning_address to display a warning in private buffer if the remote nick address has changed (issue NixOS#892)
    - irc: add server option "ssl_password" (issue NixOS#115, issue NixOS#1416)
    - irc: add "user" in output of irc_message_parse (issue NixOS#136)
    - irc: add options irc.color.message_kick and irc.color.reason_kick (issue NixOS#683, issue NixOS#684)
    - logger: add option logger.file.color_lines (issue NixOS#528, issue NixOS#621)
    - script: add options "-ol" and "-il" in command "/script list" to send translated string with list of scripts loaded, display "No scripts loaded" if no scripts are loaded
    - xfer: add option xfer.file.download_temporary_suffix with default value ".part" (issue NixOS#1237)

  Bug fixes
    - core: set buffer name, short name and title only if the value has changed
    - core: fix scrolling up in bare mode when switched to bare mode at the top of the buffer (issue NixOS#899, issue NixOS#978)
    - core: optimize load of configuration files
    - core: fix window separators not respecting window splits (issue NixOS#630)
    - core: fix cursor mode info when prefix_align is none and with words split across lines (issue NixOS#610, issue NixOS#617, issue NixOS#619)
    - core: add support of reverse video in ANSI color codes
    - core: fixed segfault during excessive evaluation in function string_repeat (issue NixOS#1400)
    - buflist: fix extra spaces between buffers when conditions are used to hide buffers (regression introduced in version 2.6) (issue NixOS#1403)
    - irc: do not automatically open a channel with name "0" (issue NixOS#1429)
    - irc: remove option irc.network.channel_encode, add server option "charset_message" to control which part of the IRC message is decoded/encoded to the target charset (issue NixOS#832)
    - irc: use path from option xfer.file.upload_path to complete filename in command "/dcc send" (issue NixOS#60)
    - logger: fix write in log file if it has been deleted or renamed (issue NixOS#123)
    - python: send "bytes" instead of "str" to callbacks in Python 3 when the string is not UTF-8 valid (issue NixOS#1389)
    - relay: send message "_buffer_title_changed" to clients only when the title is changed
    - xfer: fix memory leak when a xfer is freed and when the plugin is unloaded

  Tests
    - unit: add tests on GUI color functions

  Build
    - core: fix build on Haiku (issue NixOS#1420)
    - core: fix build on Alpine
    - core: remove file FindTCL.cmake
    - core: display an error on missing dependency in CMake (issue NixOS#916, issue NixOS#956)
    - debian: disable Javascript plugin on Debian Sid and Ubuntu Eoan
    - debian: build with Guile 2.2
    - guile: add support of Guile 2.2, disable /guile eval (issue NixOS#1098)
    - python: add detection of Python 3.8

[1] https://weechat.org/files/changelog/ChangeLog-2.7.html

(cherry picked from commit d1cb8bf)
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Feb 20, 2020
@mweinelt
weechat: 2.6 -> 2.7
4bbadcf 
Disables support for Javascript and PHP:
- Javascript requires an old version of v8
- PHP requires a larger number of dependencies in addition to php-embed

Changelog [1]:

  New features
    - core: add option weechat.look.nick_color_hash_salt to shuffle nick colors (issue NixOS#635)
    - core: add different icons sizes (16x16 to 512x512) (issue NixOS#1347)
    - core: add file weechat.desktop
    - core: add reverse of string for screen in evaluation of expressions with "revscr:"
    - core: add length of string (number of chars and on screen) in evaluation of expressions with "length:xxx" and "lengthscr:xxx"
    - core: add calculation of expression in evaluation of expressions with "calc:xxx" (issue NixOS#997)
    - core: add optional default path (evaluated) in completion "filename"
    - core: add support of modifiers in evaluation of expressions with "modifier:name,data,string"
    - api: add modifier "color_encode_ansi" (issue NixOS#528)
    - api: add modifier "eval_path_home"
    - irc: add filters on raw buffer (issue NixOS#1000)
    - irc: add option irc.look.display_pv_warning_address to display a warning in private buffer if the remote nick address has changed (issue NixOS#892)
    - irc: add server option "ssl_password" (issue NixOS#115, issue NixOS#1416)
    - irc: add "user" in output of irc_message_parse (issue NixOS#136)
    - irc: add options irc.color.message_kick and irc.color.reason_kick (issue NixOS#683, issue NixOS#684)
    - logger: add option logger.file.color_lines (issue NixOS#528, issue NixOS#621)
    - script: add options "-ol" and "-il" in command "/script list" to send translated string with list of scripts loaded, display "No scripts loaded" if no scripts are loaded
    - xfer: add option xfer.file.download_temporary_suffix with default value ".part" (issue NixOS#1237)

  Bug fixes
    - core: set buffer name, short name and title only if the value has changed
    - core: fix scrolling up in bare mode when switched to bare mode at the top of the buffer (issue NixOS#899, issue NixOS#978)
    - core: optimize load of configuration files
    - core: fix window separators not respecting window splits (issue NixOS#630)
    - core: fix cursor mode info when prefix_align is none and with words split across lines (issue NixOS#610, issue NixOS#617, issue NixOS#619)
    - core: add support of reverse video in ANSI color codes
    - core: fixed segfault during excessive evaluation in function string_repeat (issue NixOS#1400)
    - buflist: fix extra spaces between buffers when conditions are used to hide buffers (regression introduced in version 2.6) (issue NixOS#1403)
    - irc: do not automatically open a channel with name "0" (issue NixOS#1429)
    - irc: remove option irc.network.channel_encode, add server option "charset_message" to control which part of the IRC message is decoded/encoded to the target charset (issue NixOS#832)
    - irc: use path from option xfer.file.upload_path to complete filename in command "/dcc send" (issue NixOS#60)
    - logger: fix write in log file if it has been deleted or renamed (issue NixOS#123)
    - python: send "bytes" instead of "str" to callbacks in Python 3 when the string is not UTF-8 valid (issue NixOS#1389)
    - relay: send message "_buffer_title_changed" to clients only when the title is changed
    - xfer: fix memory leak when a xfer is freed and when the plugin is unloaded

  Tests
    - unit: add tests on GUI color functions

  Build
    - core: fix build on Haiku (issue NixOS#1420)
    - core: fix build on Alpine
    - core: remove file FindTCL.cmake
    - core: display an error on missing dependency in CMake (issue NixOS#916, issue NixOS#956)
    - debian: disable Javascript plugin on Debian Sid and Ubuntu Eoan
    - debian: build with Guile 2.2
    - guile: add support of Guile 2.2, disable /guile eval (issue NixOS#1098)
    - python: add detection of Python 3.8

[1] https://weechat.org/files/changelog/ChangeLog-2.7.html

(cherry picked from commit d1cb8bf)
djfroofy pushed a commit to djfroofy/nixpkgs that referenced this issue Feb 23, 2020
@mweinelt
weechat: 2.6 -> 2.7
3630c84 
Disables support for Javascript and PHP:
- Javascript requires an old version of v8
- PHP requires a larger number of dependencies in addition to php-embed

Changelog [1]:

  New features
    - core: add option weechat.look.nick_color_hash_salt to shuffle nick colors (issue NixOS#635)
    - core: add different icons sizes (16x16 to 512x512) (issue NixOS#1347)
    - core: add file weechat.desktop
    - core: add reverse of string for screen in evaluation of expressions with "revscr:"
    - core: add length of string (number of chars and on screen) in evaluation of expressions with "length:xxx" and "lengthscr:xxx"
    - core: add calculation of expression in evaluation of expressions with "calc:xxx" (issue NixOS#997)
    - core: add optional default path (evaluated) in completion "filename"
    - core: add support of modifiers in evaluation of expressions with "modifier:name,data,string"
    - api: add modifier "color_encode_ansi" (issue NixOS#528)
    - api: add modifier "eval_path_home"
    - irc: add filters on raw buffer (issue NixOS#1000)
    - irc: add option irc.look.display_pv_warning_address to display a warning in private buffer if the remote nick address has changed (issue NixOS#892)
    - irc: add server option "ssl_password" (issue NixOS#115, issue NixOS#1416)
    - irc: add "user" in output of irc_message_parse (issue NixOS#136)
    - irc: add options irc.color.message_kick and irc.color.reason_kick (issue NixOS#683, issue NixOS#684)
    - logger: add option logger.file.color_lines (issue NixOS#528, issue NixOS#621)
    - script: add options "-ol" and "-il" in command "/script list" to send translated string with list of scripts loaded, display "No scripts loaded" if no scripts are loaded
    - xfer: add option xfer.file.download_temporary_suffix with default value ".part" (issue NixOS#1237)

  Bug fixes
    - core: set buffer name, short name and title only if the value has changed
    - core: fix scrolling up in bare mode when switched to bare mode at the top of the buffer (issue NixOS#899, issue NixOS#978)
    - core: optimize load of configuration files
    - core: fix window separators not respecting window splits (issue NixOS#630)
    - core: fix cursor mode info when prefix_align is none and with words split across lines (issue NixOS#610, issue NixOS#617, issue NixOS#619)
    - core: add support of reverse video in ANSI color codes
    - core: fixed segfault during excessive evaluation in function string_repeat (issue NixOS#1400)
    - buflist: fix extra spaces between buffers when conditions are used to hide buffers (regression introduced in version 2.6) (issue NixOS#1403)
    - irc: do not automatically open a channel with name "0" (issue NixOS#1429)
    - irc: remove option irc.network.channel_encode, add server option "charset_message" to control which part of the IRC message is decoded/encoded to the target charset (issue NixOS#832)
    - irc: use path from option xfer.file.upload_path to complete filename in command "/dcc send" (issue NixOS#60)
    - logger: fix write in log file if it has been deleted or renamed (issue NixOS#123)
    - python: send "bytes" instead of "str" to callbacks in Python 3 when the string is not UTF-8 valid (issue NixOS#1389)
    - relay: send message "_buffer_title_changed" to clients only when the title is changed
    - xfer: fix memory leak when a xfer is freed and when the plugin is unloaded

  Tests
    - unit: add tests on GUI color functions

  Build
    - core: fix build on Haiku (issue NixOS#1420)
    - core: fix build on Alpine
    - core: remove file FindTCL.cmake
    - core: display an error on missing dependency in CMake (issue NixOS#916, issue NixOS#956)
    - debian: disable Javascript plugin on Debian Sid and Ubuntu Eoan
    - debian: build with Guile 2.2
    - guile: add support of Guile 2.2, disable /guile eval (issue NixOS#1098)
    - python: add detection of Python 3.8

[1] https://weechat.org/files/changelog/ChangeLog-2.7.html

(cherry picked from commit d1cb8bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shlevy shlevy

Labels
None yet
Projects
None yet
Milestone
14.04
Development

No branches or pull requests
2 participants
@shlevy @edolstra