Mark wshowkeys as broken or drop

[berbiche]

Describe the bug

wshowkeys has been broken for a few Sway/wlroots releases I believe.

I didn't find any active fork of the project to replace it so I'm in favor of dropping the package.
I don't know the procedure to drop a package though.

To Reproduce

{
  environment.systemPackages = [ pkgs.wshowkeys ];
  security.wrappers.wshowkeys.source = "${pkgs.wshowkeys}/bin/wshowkeys";
}

$ WAYLAND_DEBUG=1 wshowkeys -a top
[1164038.895]  -> [email protected]_registry(new id wl_registry@2)
[1164038.910]  -> [email protected](new id wl_callback@3)
[1164038.966] [email protected]_id(3)
[1164038.971] [email protected](1, "wl_shm", 1)
[1164038.977]  -> [email protected](1, "wl_shm", 1, new id [unknown]@4)
[1164038.983] [email protected](2, "wl_drm", 2)
[1164038.990] [email protected](3, "zwp_linux_dmabuf_v1", 3)
[1164038.997] [email protected](4, "wl_compositor", 4)
[1164039.004]  -> [email protected](4, "wl_compositor", 4, new id [unknown]@5)
[1164039.009] [email protected](5, "wl_subcompositor", 1)
[1164039.014] [email protected](6, "wl_data_device_manager", 3)
[1164039.018] [email protected](7, "zwlr_gamma_control_manager_v1", 1)
[1164039.025] [email protected](8, "zxdg_output_manager_v1", 3)
[1164039.031]  -> [email protected](8, "zxdg_output_manager_v1", 1, new id [unknown]@6)
[1164039.039] [email protected](9, "org_kde_kwin_idle", 1)
[1164039.045] [email protected](10, "zwp_idle_inhibit_manager_v1", 1)
[1164039.053] [email protected](11, "zwlr_layer_shell_v1", 4)
[1164039.062]  -> [email protected](11, "zwlr_layer_shell_v1", 1, new id [unknown]@7)
[1164039.071] [email protected](12, "xdg_wm_base", 2)
[1164039.078] [email protected](13, "zwp_tablet_manager_v2", 1)
[1164039.085] [email protected](14, "org_kde_kwin_server_decoration_manager", 1)
[1164039.095] [email protected](15, "zxdg_decoration_manager_v1", 1)
[1164039.101] [email protected](16, "zwp_relative_pointer_manager_v1", 1)
[1164039.108] [email protected](17, "zwp_pointer_constraints_v1", 1)
[1164039.115] [email protected](18, "wp_presentation", 1)
[1164039.120] [email protected](19, "zwlr_output_manager_v1", 2)
[1164039.128] [email protected](20, "zwlr_output_power_manager_v1", 1)
[1164039.132] [email protected](21, "zwp_input_method_manager_v2", 1)
[1164039.140] [email protected](22, "zwp_text_input_manager_v3", 1)
[1164039.146] [email protected](23, "zwlr_foreign_toplevel_manager_v1", 3)
[1164039.151] [email protected](24, "zwlr_export_dmabuf_manager_v1", 1)
[1164039.156] [email protected](25, "zwlr_screencopy_manager_v1", 3)
[1164039.165] [email protected](26, "zwlr_data_control_manager_v1", 2)
[1164039.170] [email protected](27, "zwp_primary_selection_device_manager_v1", 1)
[1164039.177] [email protected](28, "wp_viewporter", 1)
[1164039.185] [email protected](29, "zxdg_exporter_v1", 1)
[1164039.190] [email protected](30, "zxdg_importer_v1", 1)
[1164039.197] [email protected](31, "zxdg_exporter_v2", 1)
[1164039.203] [email protected](32, "zxdg_importer_v2", 1)
[1164039.209] [email protected](33, "xdg_activation_v1", 1)
[1164039.217] [email protected](34, "zwp_virtual_keyboard_manager_v1", 1)
[1164039.223] [email protected](35, "zwlr_virtual_pointer_manager_v1", 2)
[1164039.229] [email protected](36, "zwlr_input_inhibit_manager_v1", 1)
[1164039.236] [email protected](37, "zwp_keyboard_shortcuts_inhibit_manager_v1", 1)
[1164039.245] [email protected](38, "wl_seat", 7)
[1164039.251]  -> [email protected](38, "wl_seat", 5, new id [unknown]@8)
[1164039.263] [email protected](39, "zwp_pointer_gestures_v1", 1)
[1164039.268] [email protected](43, "wl_output", 3)
[1164039.278]  -> [email protected](43, "wl_output", 3, new id [unknown]@9)
[1164039.287] [email protected](47193)
[1164039.290]  -> [email protected](new id wl_callback@3)
[1164039.329] [email protected]_id(3)
[1164039.332] [email protected]("seat0")
[1164182.928] [email protected](3)
[1164182.939]  -> [email protected]_keyboard(new id wl_keyboard@10)
[1164182.945] [email protected](0, 0, 1190, 340, 0, "Samsung Electric Company", "LC49G95T", 0)
[1164182.958] [email protected](1, 5120, 1440, 239761)
[1164182.970] [email protected](1)
[1164182.974] [email protected]()
[1164182.976] [email protected](47193)
[1164182.979]  -> [email protected]_surface(new id wl_surface@3)
[1164182.983]  -> [email protected]_layer_surface(new id zwlr_layer_surface_v1@11, wl_surface@3, nil, 2, "showkeys")
[1164182.995]  -> [email protected]_anchor(1)
[1164182.998]  -> [email protected]_margin(32, 32, 32, 32)
[1164183.004]  -> [email protected]_exclusive_zone(-1)
[1164183.007]  -> [email protected]()
[1164183.233]  -> [email protected](nil, 0, 0)
[1164183.246]  -> [email protected]()
[1164183.254] [email protected](zwlr_layer_surface_v1@11, 1, "width 0 requested without setting left and right anchors")
zwlr_layer_surface_v1@11: error 1: width 0 requested without setting left and right anchors
wl_display_dispatch: Protocol error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Notify maintainers

@primeos

Metadata

• system: "x86_64-linux"
• host os: Linux 5.12.9-zen1, NixOS, 21.11.20210626.2274a92 (Porcupine)
• multi-user?: yes
• sandbox: yes
• version: nix-env (Nix) 2.4pre20210601_5985b8b
• channels(root): ""
• channels(nicolas): ""
• nixpkgs: /nix/store/v0rgy190p0afr4j2m2ifzpk6nlcmcmj6-5ix7h6cydwnbz46f94dvqhfiiggp8xwd-source

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute: wshowkeys
# a list of nixos modules affected by the problem
module:

[berbiche]

We will also need to update #57602

[primeos]

I didn't find any active fork of the project to replace it so I'm in favor of dropping the package.

+1

I don't know the procedure to drop a package though.

Not sure if we have an official procedure but in this case I'd use meta.broken first and then remove the package after a while (if no one complains). There's also throw but I don't think we need it here.

I've just opened #129670 for it.

We will also need to update #57602

Done (although the package list is probably outdated anyway :o)

[x10an14]

Is it okay if I hijack this issue (now closed) to ask how you guys get it to work even that much?

I've struggled just getting past the setuid issue.

[primeos]

I've struggled just getting past the setuid issue.

On NixOS: programs.wshowkeys.enable ;)

[bhepple]

There's a new repo with a fix for this at https://github.com/ammgws/wshowkeys

Discussion at https://www.reddit.com/r/swaywm/comments/ovfzpv/new_custodianmaintainerbugfix_needed_for_wshowkeys/

[Artturin]

#139777