Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texinfo: texinfoInteractive t/malformed-split.sh hangs #108675

Closed
raboof opened this issue Jan 7, 2021 · 10 comments · Fixed by #108708
Closed

texinfo: texinfoInteractive t/malformed-split.sh hangs #108675

raboof opened this issue Jan 7, 2021 · 10 comments · Fixed by #108708
Labels
0.kind: bug Something is broken 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md

Comments

@raboof
Copy link
Member

raboof commented Jan 7, 2021

Describe the bug

When (re)building texinfoInteractive, all tests up until t/split.sh pass, but t/malformed-split.sh hangs.

To Reproduce
Steps to reproduce the behavior:

nix-build '<nixpkgs>' -A texinfoInteractive --check (in my case on nixos-unstable, 1a57d96 and d9dba88)

Additional context

Interesting comment at https://www.mail-archive.com/[email protected]/msg08053.html

@raboof raboof added the 0.kind: bug Something is broken label Jan 7, 2021
@andir
Copy link
Member

andir commented Jan 7, 2021

What revision was this on? I've just tried to reproduce this but the package did build just fine on 1a57d96.

@andir
Copy link
Member

andir commented Jan 7, 2021

Also works for me on the current master branch: c1891ad

@raboof
Copy link
Member Author

raboof commented Jan 7, 2021

rebooting and switching terminal/shell didn't help.

it works for me on 950c5e1 (after a 'nixos-rebuild switch') though, so I can bisect where it started going wrong for me...

@raboof
Copy link
Member Author

raboof commented Jan 7, 2021

adding --option sandbox yes doesn't change the behaviour.

bisecting shows the problem started since the upgrade of busybox from 1.31.1 to 1.32.0 in 565c6a2 . Indeed https://busybox.net/?var=a mentions 1.32.1 fixes a deadlock issue, and indeed upgrading busybox fixes the problem for me \o/. Will PR.

@raboof raboof mentioned this issue Jan 7, 2021
10 tasks
raboof added a commit to raboof/nixpkgs that referenced this issue Jan 8, 2021
Fixes NixOS#108675, a tty deadlock issue that affected one of the
texinfoInteractive tests.

Co-Authored-By: Sandro <[email protected]>
@TredwellGit
Copy link
Member

#108708 did not fix this.

@TredwellGit TredwellGit reopened this Jan 10, 2021
@raboof
Copy link
Member Author

raboof commented Jan 10, 2021

#108708 did not fix this.

Hmm, I just double-checked and it does fix it for me: hangs on 66dc4881b2f6b8415d2afaaa178f481b660c7a52^ and succeeds on 66dc4881b2f6b8415d2afaaa178f481b660c7a52.

I have to actually nixos-rebuild switch for the fix to take effect, though: updating the nixpkgs used by nix-build isn't sufficient.

@TredwellGit
Copy link
Member

I can't nixos-rebuild switch because it hangs. That is also really unusual behavior.

@raboof
Copy link
Member Author

raboof commented Jan 10, 2021

That is also really unusual behavior.

It is, isn't it!

@stale
Copy link

stale bot commented Jul 9, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 9, 2021
@Artturin
Copy link
Member

It's 2 years later and busybox is at 1.36 so perhaps it's fixed now

@Artturin Artturin closed this as not planned Won't fix, can't repro, duplicate, stale Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants