Skip to content

Commit

Permalink
rapidjson: skip a regressed test
Browse files Browse the repository at this point in the history
I don't think this is serious.  Surely it doesn't indicate a bug
in glibc.  And if it indicates a non-test bug in rapidjson,
it's not a new one and probably won't be worse with new glibc.
  • Loading branch information
vcunat authored and Ma27 committed Aug 20, 2023
1 parent e089c4f commit baab441
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkgs/development/libraries/rapidjson/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ stdenv.mkDerivation rec {
url = "https://git.alpinelinux.org/aports/plain/community/rapidjson/do-not-include-gtest-src-dir.patch?id=9e5eefc7a5fcf5938a8dc8a3be8c75e9e6809909";
hash = "sha256-BjSZEwfCXA/9V+kxQ/2JPWbc26jQn35CfN8+8NW24s4=";
})
# One of these three tests reports memcpy overlap after update to glibc-2.38
./test-skip-valgrind.diff
];

postPatch = ''
Expand Down
7 changes: 7 additions & 0 deletions pkgs/development/libraries/rapidjson/test-skip-valgrind.diff
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
--- a/test/unittest/CMakeLists.txt
+++ b/test/unittest/CMakeLists.txt
@@ -82,3 +81,0 @@
- add_test(NAME valgrind_unittest
- COMMAND valgrind --leak-check=full --error-exitcode=1 ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/unittest --gtest_filter=-SIMD.*
- WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/bin)

0 comments on commit baab441

Please sign in to comment.