lib.types.attrsWith: add some more unit tests

lib/tests/modules.sh

@@ -570,6 +570,11 @@ checkConfigOutput '^38|27$' options.submoduleLine38.declarationPositions.1.line
 # nested options work
 checkConfigOutput '^34$' options.nested.nestedLine34.declarationPositions.0.line ./declaration-positions.nix
 
+# AttrsWith tests
+checkConfigOutput '^11$' config.result ./lazy-attrsWith.nix
+checkConfigOutput '^"mergedName.<id>.nested"$' config.result ./name-merge-attrsWith-1.nix
+checkConfigError 'The option .mergedName. in .*\.nix. is already declared in .*\.nix' config.mergedName ./name-merge-attrsWith-2.nix
+
 cat <<EOF
 ====== module tests ======
 $pass Pass

lib/tests/modules/lazy-attrsWith.nix

@@ -0,0 +1,45 @@
+# Check that AttrsWith { lazy = true; } is lazy
+{ lib, ... }:
+let
+  inherit (lib) types mkOption;
+in
+{
+  imports = [
+    #  Module A
+    (
+      { ... }:
+      {
+        options.mergedLazy = mkOption {
+          # Same as lazyAttrsOf
+          type = types.attrsWith {
+            lazy = true;
+            elemType = types.int;
+          };
+        };
+      }
+    )
+    # Module B
+    (
+      { ... }:
+      {
+        options.mergedLazy = lib.mkOption {
+          # Same as lazyAttrsOf
+          type = types.attrsWith {
+            lazy = true;
+            elemType = types.int;
+          };
+        };
+      }
+    )
+    # Result
+    (
+      { config, ... }:
+      {
+        # Can only evaluate if lazy
+        config.mergedLazy.bar = config.mergedLazy.baz + 1;
+        config.mergedLazy.baz = 10;
+        options.result = mkOption { default = config.mergedLazy.bar; };
+      }
+    )
+  ];
+}

lib/tests/modules/name-merge-attrsWith-1.nix

@@ -0,0 +1,53 @@
+# Check that AttrsWith { lazy = true; } is lazy
+{ lib, ... }:
+let
+  inherit (lib) types mkOption;
+in
+{
+  imports = [
+    # Module A
+    (
+      { ... }:
+      {
+        options.mergedName = mkOption {
+          default = { };
+          type = types.attrsWith {
+            # Declare <name> = "id"
+            name = "id";
+            elemType = types.submodule {
+              options.nested = mkOption {
+                type = types.int;
+                default = 1;
+              };
+            };
+          };
+        };
+      }
+    )
+    # Module B
+    (
+      { ... }:
+      {
+        options.mergedName = mkOption {
+          # default: "<name>"
+          type = types.attrsOf (types.submodule { });
+          # default = {};
+        };
+      }
+    )
+
+    # Output
+    (
+      {
+        options,
+        ...
+      }:
+      {
+        options.result = mkOption {
+          default = lib.concatStringsSep "." (options.mergedName.type.getSubOptions options.mergedName.loc)
+          .nested.loc;
+        };
+      }
+    )
+  ];
+}

lib/tests/modules/name-merge-attrsWith-2.nix

@@ -0,0 +1,39 @@
+# Non mergable attrsWith
+{ lib, ... }:
+let
+  inherit (lib) types mkOption;
+in
+{
+  imports = [
+    # Module A
+    (
+      { ... }:
+      {
+        options.mergedName = mkOption {
+          default = { };
+          type = types.attrsWith {
+            name = "id";
+            elemType = types.submodule {
+              options.nested = mkOption {
+                type = types.int;
+                default = 1;
+              };
+            };
+          };
+        };
+      }
+    )
+    # Module B
+    (
+      { ... }:
+      {
+        options.mergedName = mkOption {
+          type = types.attrsWith {
+            name = "other";
+            elemType = types.submodule { };
+          };
+        };
+      }
+    )
+  ];
+}

lib/types.nix

@@ -617,9 +617,9 @@ rec {
       getSubModules = elemType.getSubModules;
       substSubModules = m: attrsWith { elemType = elemType.substSubModules m; inherit name lazy; };
       functor = defaultFunctor "attrsWith" // {
-        wrapped = elemType;
-        type = t: attrsWith { elemType = t; inherit name lazy; };
+        type = payload: attrsWith payload;
         payload = {
+          # Important!: Add new function attributes here in case of future changes
           inherit elemType name lazy;
         };
         binOp = lhs: rhs: