Skip to content

Commit

Permalink
nixos/modules/misc/version.nix: Don't spam the user with vague warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
@edolstra
edolstra committed Aug 10, 2018
1 parent 68b5f51 commit 4d1332e
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions nixos/modules/misc/version.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,6 @@ in

config = {

warnings = lib.optional (options.system.stateVersion.highestPrio > 1000)
"You don't have `system.stateVersion` explicitly set. Expect things to break.";

system.nixos = {
# These defaults are set here rather than up there so that
# changing them would not rebuild the manual
Expand Down

3 comments on commit 4d1332e

@xeji
Copy link
Contributor

@xeji xeji commented on 4d1332e Aug 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @oxij who, IIRC, added this warning a while ago

@oxij
Copy link
Member

@oxij oxij commented on 4d1332e Aug 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we had discussed this in 1f0b692#commitcomment-29001452 Everything I've written there is still valid: this warning is not the best thing ever (stateVersion should be modularized), but (until that's done) having a warning is better than Postgres/MariaDB silently screwing your on-disk state between upgrades.

Another thing I'll have to re-cherry-pick in SLNOS, I guess.

@Ericson2314
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah to flip it around, it's crazy that we'd migrate any user data without giving some sort of warning. Yet that's precisely what his commit does.

Please sign in to comment.