Skip to content

Commit

Permalink
nixosTests.ldap: remove
Browse files Browse the repository at this point in the history
This seems to have worked in 15f105d (5
months ago) but broke somewhere in the meantime.

The current module doesn't seem to be underdocumented and might need a
serious refactor. It requires quite some hacks to get it to work (see
#86305 (comment)),
or how the ldap.nix test used systemd.services.openldap.preStart and
made quite some assumptions on internals.

Mic92 agreed on being added as a maintainer for the module, as he uses
it a lot and can possibly fix eventual breakages. For the most basic
startup breakages, the remaining openldap.nix test might suffice.
  • Loading branch information
flokli committed May 6, 2020
1 parent 19d2c06 commit 450f8a4
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 406 deletions.
4 changes: 4 additions & 0 deletions nixos/modules/services/databases/openldap.nix
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,10 @@ in

};

meta = {
maintainers = lib.maintainers.mic92;
};


###### implementation

Expand Down
1 change: 0 additions & 1 deletion nixos/tests/all-tests.nix
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,6 @@ in
kubernetes.rbac = handleTestOn ["x86_64-linux"] ./kubernetes/rbac.nix {};
latestKernel.hardened = handleTest ./hardened.nix { latestKernel = true; };
latestKernel.login = handleTest ./login.nix { latestKernel = true; };
ldap = handleTest ./ldap.nix {};
leaps = handleTest ./leaps.nix {};
lidarr = handleTest ./lidarr.nix {};
lightdm = handleTest ./lightdm.nix {};
Expand Down
Loading

0 comments on commit 450f8a4

Please sign in to comment.