Skip to content

Commit

Permalink
python3Packages.Flask: 2.0.3 -> 2.1.1
Browse files Browse the repository at this point in the history
  • Loading branch information
@mweinelt
mweinelt committed Apr 14, 2022
1 parent e103631 commit 3caf52b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkgs/development/python-modules/flask/default.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
}:

buildPythonPackage rec {
version = "2.0.3";
version = "2.1.1";
pname = "Flask";

src = fetchPypi {
inherit pname version;
sha256 = "sha256-4RIMIoyi9VO0cN9KX6knq2YlhGdSYGmYGz6wqRkCaH0=";
sha256 = "sha256-qMm9PlWOyZZG0Xepc5xB3x3tBilIC0yNKXVBLzyVGcg=";
};

propagatedBuildInputs = [
Expand Down

5 comments on commit 3caf52b

@samuela
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change broke sentry-sdk, wandb, and likely many others. See #169130 for example. Please run nixpkgs-review before merging in the future.

Please fix these issues, or revert this change. If I don't hear back, I'll go ahead and revert tomorrow.

Also, what PR was this associated with?

@mweinelt
Copy link
Member Author

@mweinelt mweinelt commented on 3caf52b Apr 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

#166489

Some dependencies update, others don't. We can't always please everyone.

@samuela
Copy link
Member

@samuela samuela commented on 3caf52b Apr 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand but you can't randomly break other packages. How can we use flask 2.0.3 in order to avoid the breakages caused by this commit?

Note also that this is currently breaking pgadmin4 #169322.

@mweinelt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With buildPythonApplication use packageOverrides as described in https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#overriding-python-packages-overriding-python-packages, for libraries you have to check with your upstream. Look for patches and open issues.

@samuela
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, could you please submit a PR to sentry-sdk with the appropriate packageOverrides then? The issue is already tracked upstream at getsentry/sentry-python#1398 and in nixpkgs at #169130.

Please sign in to comment.