-
-
Notifications
You must be signed in to change notification settings - Fork 14k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
lib.modules.doRename: Add condition parameter
This is to support single-to-multi service migrations, so that the `to` (e.g. `foos.""`) isn't defined unconditionally. See test cases.
- Loading branch information
Showing
6 changed files
with
77 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ config, lib, ... }: | ||
{ | ||
config = { | ||
services.foo.enable = true; | ||
services.foo.bar = "baz"; | ||
result = | ||
assert config.services.foos == { "" = { bar = "baz"; }; }; | ||
true; | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ config, lib, ... }: | ||
{ | ||
config = { | ||
services.foos."".bar = "baz"; | ||
result = | ||
assert config.services.foos == { "" = { bar = "baz"; }; }; | ||
assert config.services.foo.bar == "baz"; | ||
true; | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ config, lib, options, ... }: | ||
{ | ||
config = { | ||
result = | ||
assert config.services.foos == { }; | ||
assert ! options.services.foo.bar.isDefined; | ||
true; | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/* | ||
Simulate a migration from a single-instance `services.foo` to a multi instance | ||
`services.foos.<name>` module, where `name = ""` serves as the legacy / | ||
compatibility instance. | ||
- No instances must exist, unless one is defined in the multi-instance module, | ||
or if the legacy enable option is set to true. | ||
- The legacy instance options must be renamed to the new instance, if it exists. | ||
The relevant scenarios are tested in separate files: | ||
- ./doRename-condition-enable.nix | ||
- ./doRename-condition-no-enable.nix | ||
*/ | ||
{ config, lib, ... }: | ||
let | ||
inherit (lib) mkOption mkEnableOption types doRename; | ||
in | ||
{ | ||
options = { | ||
services.foo.enable = mkEnableOption "foo"; | ||
services.foos = mkOption { | ||
type = types.attrsOf (types.submodule { | ||
options = { | ||
bar = mkOption { type = types.str; }; | ||
}; | ||
}); | ||
default = { }; | ||
}; | ||
result = mkOption {}; | ||
}; | ||
imports = [ | ||
(doRename { | ||
from = [ "services" "foo" "bar" ]; | ||
to = [ "services" "foos" "" "bar" ]; | ||
visible = true; | ||
warn = false; | ||
use = x: x; | ||
withPriority = true; | ||
condition = config.services.foo.enable; | ||
}) | ||
]; | ||
} |