You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
@abbradar: at this commit you differ at a few lines from gcc-6. Do you remember reasons for those differences?
In particular, flex addition seems unnecessary and would break bootstrapping currently if using gcc-7 by default (due to fetchpatch in flex). You also removed the use-source-date-epoch.patch. Could these be unintentional differences, perhaps caused by rebasing/cherry-picking?
0dc5473
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abbradar: at this commit you differ at a few lines from gcc-6. Do you remember reasons for those differences?
In particular,
flex
addition seems unnecessary and would break bootstrapping currently if using gcc-7 by default (due tofetchpatch
inflex
). You also removed theuse-source-date-epoch.patch
. Could these be unintentional differences, perhaps caused by rebasing/cherry-picking?0dc5473
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it (rebasing shenanigans): diff also shows this comment:
and I don't know what is this all about at all. Let's then synchronize with GCC 6.
0dc5473
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we might stop copying version-controlled files...
0dc5473
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, gcc-7 has sensitivity to
$SOURCE_DATE_EPOCH
built in, so the patch is useless now (and doesn't apply).0dc5473
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I look now at possibility of unifying our GCC packages -- maybe this would be simpler than I thought...
0dc5473
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The syncing commit: 3610d63